Skip to content

Commit 5fde81e

Browse files
committed
comments
1 parent db5f224 commit 5fde81e

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

dbos/dbos.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ func (c *dbosContext) Launch() error {
380380
// The method blocks until all workflows complete or the timeout expires. If the timeout is reached
381381
// while workflows are still running, a warning is logged but the method continues.
382382
//
383-
// Cancel is called internally by Shutdown and handles only the core cancellation operations.
383+
// Cancel is called internally by Shutdown.
384384
// It is a permanent operation that should be used when the application is shutting down or deactivated.
385385
func (c *dbosContext) Cancel(timeout time.Duration) {
386386
c.logger.Info("Cancelling DBOS context")
@@ -410,13 +410,12 @@ func (c *dbosContext) Cancel(timeout time.Duration) {
410410
// 1. Calls Cancel to stop workflows and cancel the context
411411
// 2. Waits for the queue runner to complete processing
412412
// 3. Stops the workflow scheduler and waits for scheduled jobs to finish
413-
// 4. Shuts down the system database connection pool
414-
// 5. Shuts down the admin server (if running)
413+
// 4. Shuts down the system database connection pool and notification listener
414+
// 5. Shuts down the admin server
415415
// 6. Marks the context as not launched
416416
//
417417
// Each step respects the provided timeout. If any component doesn't shut down within the timeout,
418-
// a warning is logged and the shutdown continues to the next component. This ensures that even
419-
// if one component hangs, the others can still be cleaned up properly.
418+
// a warning is logged and the shutdown continues to the next component.
420419
//
421420
// Shutdown is a permanent operation and should be called when the application is terminating.
422421
func (c *dbosContext) Shutdown(timeout time.Duration) {

0 commit comments

Comments
 (0)