Skip to content

Commit 6d294d9

Browse files
committed
wait stuck on gha?
1 parent 40a9bcf commit 6d294d9

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

cmd/dbos/cli_integration_test.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414
"os/exec"
1515
"path/filepath"
1616
"runtime"
17-
"syscall"
1817
"testing"
1918
"time"
2019

@@ -105,14 +104,7 @@ func TestCLIWorkflow(t *testing.T) {
105104
fmt.Println(cmd.Stderr)
106105
fmt.Println(cmd.Stdout)
107106
*/
108-
// Kill the entire process group
109-
pgid, err := syscall.Getpgid(cmd.Process.Pid)
110-
if err == nil {
111-
syscall.Kill(-pgid, syscall.SIGKILL)
112-
} else {
113-
cmd.Process.Kill()
114-
}
115-
_ = cmd.Wait() // Ignore error since we killed it
107+
cmd.Process.Kill()
116108
}
117109
})
118110
})

cmd/dbos/start.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func runStart(cmd *cobra.Command, args []string) error {
7373
return fmt.Errorf("command failed: %w", err)
7474
}
7575
case sig := <-sigChan:
76-
logger.Info("Received signal, stopping...", "signal", sig)
76+
logger.Info("Received signal, stopping...", "signal", sig.String())
7777

7878
// Kill the process group on Unix-like systems
7979
if runtime.GOOS != "windows" {

0 commit comments

Comments
 (0)