Skip to content

Commit 7f38dcf

Browse files
committed
uneeded warning
1 parent 7b87951 commit 7f38dcf

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

dbos/system_database.go

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,17 +1189,16 @@ func (s *sysDB) recordOperationResult(ctx context.Context, input recordOperation
11891189
return fmt.Errorf("failed to serialize output: %w", err)
11901190
}
11911191

1192-
var commandTag pgconn.CommandTag
11931192
if input.tx != nil {
1194-
commandTag, err = input.tx.Exec(ctx, query,
1193+
_, err = input.tx.Exec(ctx, query,
11951194
input.workflowID,
11961195
input.stepID,
11971196
outputString,
11981197
errorString,
11991198
input.stepName,
12001199
)
12011200
} else {
1202-
commandTag, err = s.pool.Exec(ctx, query,
1201+
_, err = s.pool.Exec(ctx, query,
12031202
input.workflowID,
12041203
input.stepID,
12051204
outputString,
@@ -1208,12 +1207,6 @@ func (s *sysDB) recordOperationResult(ctx context.Context, input recordOperation
12081207
)
12091208
}
12101209

1211-
/*
1212-
s.logger.Debug("RecordOperationResult CommandTag", "command_tag", commandTag)
1213-
s.logger.Debug("RecordOperationResult Rows affected", "rows_affected", commandTag.RowsAffected())
1214-
s.logger.Debug("RecordOperationResult SQL", "sql", commandTag.String())
1215-
*/
1216-
12171210
if err != nil {
12181211
s.logger.Error("RecordOperationResult Error occurred", "error", err)
12191212
if pgErr, ok := err.(*pgconn.PgError); ok && pgErr.Code == _PG_ERROR_UNIQUE_VIOLATION {
@@ -1222,10 +1215,6 @@ func (s *sysDB) recordOperationResult(ctx context.Context, input recordOperation
12221215
return err
12231216
}
12241217

1225-
if commandTag.RowsAffected() == 0 {
1226-
s.logger.Warn("RecordOperationResult No rows were affected by the insert")
1227-
}
1228-
12291218
return nil
12301219
}
12311220

0 commit comments

Comments
 (0)