Skip to content

Commit 8515031

Browse files
committed
simplify
1 parent 7a62a6c commit 8515031

File tree

1 file changed

+3
-47
lines changed

1 file changed

+3
-47
lines changed

dbos/conductor.go

Lines changed: 3 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ func (c *Conductor) handleExecutorInfoRequest(data []byte, requestID string) err
342342
Hostname: &hostname,
343343
}
344344

345-
return c.sendexecutorInfoResponse(response)
345+
return c.sendResponse(response, "executor info response")
346346
}
347347

348348
// handleRecoveryRequest handles recovery requests from the conductor
@@ -516,26 +516,6 @@ func (c *Conductor) handleRetentionRequest(data []byte, requestID string) error
516516
return c.sendResponse(response, "retention response")
517517
}
518518

519-
// sendexecutorInfoResponse sends an executorInfoResponse to the conductor
520-
func (c *Conductor) sendexecutorInfoResponse(response executorInfoResponse) error {
521-
if c.conn == nil {
522-
return fmt.Errorf("no connection")
523-
}
524-
525-
data, err := json.Marshal(response)
526-
if err != nil {
527-
return fmt.Errorf("failed to marshal executor info response: %w", err)
528-
}
529-
530-
c.logger.Debug("Sending executor info response", "data", response)
531-
532-
if err := c.conn.WriteMessage(websocket.TextMessage, data); err != nil {
533-
c.logger.Error("Failed to send executor info response", "error", err)
534-
return fmt.Errorf("failed to send message: %w", err)
535-
}
536-
537-
return nil
538-
}
539519

540520
// sendResponse sends a response to the conductor via websocket
541521
func (c *Conductor) sendResponse(response any, responseType string) error {
@@ -745,7 +725,7 @@ func (c *Conductor) handleListStepsRequest(data []byte, requestID string) error
745725
Output: nil,
746726
ErrorMessage: &errorMsg,
747727
}
748-
return c.sendListStepsResponse(response)
728+
return c.sendResponse(response, "list steps response")
749729
}
750730

751731
// Convert steps to response format
@@ -766,33 +746,9 @@ func (c *Conductor) handleListStepsRequest(data []byte, requestID string) error
766746
Output: formattedSteps,
767747
}
768748

769-
return c.sendListStepsResponse(response)
749+
return c.sendResponse(response, "list steps response")
770750
}
771751

772-
// sendListStepsResponse sends a ListStepsResponse to the conductor
773-
func (c *Conductor) sendListStepsResponse(response listStepsConductorResponse) error {
774-
if c.conn == nil {
775-
return fmt.Errorf("no connection")
776-
}
777-
778-
data, err := json.Marshal(response)
779-
if err != nil {
780-
return fmt.Errorf("failed to marshal list steps response: %w", err)
781-
}
782-
783-
var stepCount int
784-
if response.Output != nil {
785-
stepCount = len(*response.Output)
786-
}
787-
c.logger.Debug("Sending list steps response", "step_count", stepCount)
788-
789-
if err := c.conn.WriteMessage(websocket.TextMessage, data); err != nil {
790-
c.logger.Error("Failed to send list steps response", "error", err)
791-
return fmt.Errorf("failed to send message: %w", err)
792-
}
793-
794-
return nil
795-
}
796752

797753
// handleGetWorkflowRequest handles get workflow requests from the conductor
798754
func (c *Conductor) handleGetWorkflowRequest(data []byte, requestID string) error {

0 commit comments

Comments
 (0)