comments

Author: maxdml

dbos/serialization.go

@@ -77,7 +77,7 @@ func isJSONSerializer(s Serializer) bool {
 // This is needed because JSON deserialization loses type information when decoding
 // into `any` - it converts structs to map[string]interface{}, numbers to float64, etc.
 // By re-marshaling and unmarshaling into a typed target, we (mostly) restore the original structure.
-// We should be able to get ride of this when we lift encoding/decoding outside of the system database.
+// We should be able to get rid of this when we lift encoding/decoding outside of the system database.
 func convertJSONToType[T any](value any) (T, error) {
 	if value == nil {
 		return *new(T), nil

dbos/workflow.go

@@ -521,6 +521,9 @@ func RegisterWorkflow[P any, R any](ctx DBOSContext, fn Workflow[P, R], opts ...
 		if err != nil {
 			return *new(R), newWorkflowExecutionError("", fmt.Errorf("getting workflow ID: %w", err))
 		}
+		// In async execution (e.g., recoverPendingWorkflows and queue runner), we don't know the input type
+		// Here we can capture it and add the casting to the logic
+		// Note that the input might come from the database.
 		var typedInput P
 		if isJSONSerializer(ctx.(*dbosContext).serializer) {
 			var err error