comments

Author: maxdml

dbos/serialization.go

@@ -66,7 +66,6 @@ func serialize(ctx DBOSContext, data any) (string, error) {
 	return dbosCtx.serializer.Encode(data)
 }
 
-// isJSONSerializer checks if the given serializer is a JSONSerializer
 func isJSONSerializer(s Serializer) bool {
 	_, ok := s.(*JSONSerializer)
 	return ok
@@ -78,6 +77,7 @@ func isJSONSerializer(s Serializer) bool {
 // This is needed because JSON deserialization loses type information when decoding
 // into `any` - it converts structs to map[string]interface{}, numbers to float64, etc.
 // By re-marshaling and unmarshaling into a typed target, we (mostly) restore the original structure.
+// We should be able to get ride of this when we lift encoding/decoding outside of the system database.
 func convertJSONToType[T any](value any) (T, error) {
 	if value == nil {
 		return *new(T), nil