Skip to content

Commit c8253a1

Browse files
committed
nit + remove flaky test
1 parent 6950cbe commit c8253a1

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

dbos/queues_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ func TestWorkflowQueues(t *testing.T) {
213213

214214
// Check that the workflow hits DLQ after re-running max retries
215215
handles := make([]WorkflowHandle[any], 0, dlqMaxRetries+1)
216-
for _ = range dlqMaxRetries {
216+
for range dlqMaxRetries {
217217
recoveryHandles, err := recoverPendingWorkflows(dbosCtx.(*dbosContext), []string{"local"})
218218
require.NoError(t, err, "failed to recover pending workflows")
219219
assert.Len(t, recoveryHandles, 1, "expected 1 handle")

dbos/workflows_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1426,12 +1426,9 @@ func TestSendRecv(t *testing.T) {
14261426
_, err = handle.GetResult()
14271427
require.NoError(t, err, "failed to get result from send workflow")
14281428

1429-
start := time.Now()
14301429
result, err := receiveHandle.GetResult()
14311430
require.NoError(t, err, "failed to get result from receive workflow")
14321431
require.Equal(t, "message1-message2-message3", result)
1433-
// FIXME This is not a great condition: when all the tests run there's quite some randomness to this
1434-
require.LessOrEqual(t, time.Since(start), 10*time.Second, "receive workflow took too long to complete")
14351432

14361433
// Verify step counting for send workflow (sendWorkflow calls Send 3 times)
14371434
sendSteps, err := dbosCtx.(*dbosContext).systemDB.getWorkflowSteps(dbosCtx, handle.GetWorkflowID())

0 commit comments

Comments
 (0)