why the dereference

Author: maxdml

dbos/client.go

@@ -240,16 +240,16 @@ func Enqueue[P any, R any](c Client, queueName, workflowName string, input P, op
 	}
 
 	// Register the input and outputs for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if cl, ok := c.(*client); ok {
 		if ctx, ok := cl.dbosCtx.(*dbosContext); ok {
-			logger = *ctx.logger
+			logger = ctx.logger
 		}
 	}
 	var typedInput P
-	safeGobRegister(typedInput, &logger)
+	safeGobRegister(typedInput, logger)
 	var typedOutput R
-	safeGobRegister(typedOutput, &logger)
+	safeGobRegister(typedOutput, logger)
 
 	// Call the interface method with the same signature
 	handle, err := c.Enqueue(queueName, workflowName, input, opts...)

dbos/workflow.go

@@ -437,14 +437,14 @@ func RegisterWorkflow[P any, R any](ctx DBOSContext, fn Workflow[P, R], opts ...
 	fqn := runtime.FuncForPC(reflect.ValueOf(fn).Pointer()).Name()
 
 	// Registry the input/output types for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var p P
 	var r R
-	safeGobRegister(p, &logger)
-	safeGobRegister(r, &logger)
+	safeGobRegister(p, logger)
+	safeGobRegister(r, logger)
 
 	// Register a type-erased version of the durable workflow for recovery
 	typedErasedWorkflow := WorkflowFunc(func(ctx DBOSContext, input any) (any, error) {
@@ -1045,12 +1045,12 @@ func RunAsStep[R any](ctx DBOSContext, fn Step[R], opts ...StepOption) (R, error
 	}
 
 	// Register the output type for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var r R
-	safeGobRegister(r, &logger)
+	safeGobRegister(r, logger)
 
 	// Append WithStepName option to ensure the step name is set. This will not erase a user-provided step name
 	stepName := runtime.FuncForPC(reflect.ValueOf(fn).Pointer()).Name()
@@ -1213,12 +1213,12 @@ func Send[P any](ctx DBOSContext, destinationID string, message P, topic string)
 	if ctx == nil {
 		return errors.New("ctx cannot be nil")
 	}
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var typedMessage P
-	safeGobRegister(typedMessage, &logger)
+	safeGobRegister(typedMessage, logger)
 	return ctx.Send(ctx, destinationID, message, topic)
 }
 
@@ -1294,12 +1294,12 @@ func SetEvent[P any](ctx DBOSContext, key string, message P) error {
 	if ctx == nil {
 		return errors.New("ctx cannot be nil")
 	}
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var typedMessage P
-	safeGobRegister(typedMessage, &logger)
+	safeGobRegister(typedMessage, logger)
 	return ctx.SetEvent(ctx, key, message)
 }
 
@@ -1492,12 +1492,12 @@ func RetrieveWorkflow[R any](ctx DBOSContext, workflowID string) (WorkflowHandle
 	}
 
 	// Register the output for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var r R
-	safeGobRegister(r, &logger)
+	safeGobRegister(r, logger)
 
 	// Call the interface method
 	handle, err := ctx.RetrieveWorkflow(ctx, workflowID)
@@ -1590,12 +1590,12 @@ func ResumeWorkflow[R any](ctx DBOSContext, workflowID string) (WorkflowHandle[R
 	}
 
 	// Register the output for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var r R
-	safeGobRegister(r, &logger)
+	safeGobRegister(r, logger)
 
 	_, err := ctx.ResumeWorkflow(ctx, workflowID)
 	if err != nil {
@@ -1686,12 +1686,12 @@ func ForkWorkflow[R any](ctx DBOSContext, input ForkWorkflowInput) (WorkflowHand
 	}
 
 	// Register the output for gob encoding
-	var logger slog.Logger
+	var logger *slog.Logger
 	if c, ok := ctx.(*dbosContext); ok {
-		logger = *c.logger
+		logger = c.logger
 	}
 	var r R
-	safeGobRegister(r, &logger)
+	safeGobRegister(r, logger)
 
 	handle, err := ctx.ForkWorkflow(ctx, input)
 	if err != nil {