Skip to content

Conversation

@af-md
Copy link
Collaborator

@af-md af-md commented Jul 19, 2025

No description provided.

@maxdml
Copy link
Collaborator

maxdml commented Jul 20, 2025

Good catch! You are right, Send() from a workflow should check that its own ID has already executed.

We should also add a test for this case in the TestSendReceive suite. Generally speaking the suite doesn't test that Send is idempotent. The "idempotency test" in SendRecvSuccess gets the recorded result of the workflow, not step by step..

Could you add that to the PR as well 🙏? (In other tests you can find the logic that blocks a workflow artificially so that we can invoke it again with the same ID and check steps idempotency. After both invocation executes, GetWorkflowSteps should return the expected number of steps)

(we should do the idempotency test for Recv() as well. Both send and recv are special steps)

@maxdml maxdml force-pushed the send-workflowID branch from 9c4ee18 to cfe0aed Compare July 22, 2025 04:47
@af-md af-md merged commit 274525f into dbos-inc:main Jul 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants