Send get events #38
Merged
Send get events #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work fine work 1 consumer <-> 1 producer, but set/get event accepts multiple consumers
maxdml
commented
Jul 24, 2025
Comment on lines
+1179
to
+1183
| tx, err := s.pool.Begin(ctx) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to begin transaction: %w", err) | ||
| } | ||
| defer tx.Rollback(ctx) |
Collaborator
Author
There was a problem hiding this comment.
The transaction should start for the sequence:
- consume message
- record Recv() output
But not before
maxdml
commented
Jul 24, 2025
|
|
||
| return value, nil | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I trust recording the step outcome + reading the event do not need being done transactionally.
Member
There was a problem hiding this comment.
No, they don't, as it doesn't consume the event
maxdml
commented
Jul 24, 2025
Comment on lines
-1088
to
-1129
|
|
||
| // Send and receive again the same workflows to verify idempotency | ||
| _, err = sendWf(context.Background(), sendWorkflowInput{ | ||
| DestinationID: receiveHandle.GetWorkflowID(), | ||
| Topic: "test-topic", | ||
| }, WithWorkflowID(handle.GetWorkflowID())) | ||
| if err != nil { | ||
| t.Fatalf("failed to send message with same workflow ID: %v", err) | ||
| } | ||
| receiveHandle2, err := receiveWf(context.Background(), "test-topic", WithWorkflowID(receiveHandle.GetWorkflowID())) | ||
| if err != nil { | ||
| t.Fatalf("failed to start receive workflow with same ID: %v", err) | ||
| } | ||
| result, err = receiveHandle2.GetResult(context.Background()) | ||
| if err != nil { | ||
| t.Fatalf("failed to get result from receive workflow with same ID: %v", err) | ||
| } | ||
| if result != "message1-message2-message3" { | ||
| t.Fatalf("expected received message to be 'message1-message2-message3', got '%s'", result) | ||
| } | ||
|
|
||
| // Get steps for both workflows and verify we have the expected number | ||
| sendSteps, err := dbos.systemDB.GetWorkflowSteps(context.Background(), handle.GetWorkflowID()) | ||
| if err != nil { | ||
| t.Fatalf("failed to get steps for send workflow: %v", err) | ||
| } | ||
| receiveSteps, err := dbos.systemDB.GetWorkflowSteps(context.Background(), receiveHandle.GetWorkflowID()) | ||
| if err != nil { | ||
| t.Fatalf("failed to get steps for receive workflow: %v", err) | ||
| } | ||
|
|
||
| // Verify the number of steps matches the number of send() and recv() calls | ||
| // sendWorkflow has 3 Send() calls, receiveWorkflow has 3 Recv() calls | ||
| expectedSendSteps := 3 | ||
| expectedReceiveSteps := 3 | ||
|
|
||
| if len(sendSteps) != expectedSendSteps { | ||
| t.Fatalf("expected %d steps in send workflow, got %d", expectedSendSteps, len(sendSteps)) | ||
| } | ||
| if len(receiveSteps) != expectedReceiveSteps { | ||
| t.Fatalf("expected %d steps in receive workflow, got %d", expectedReceiveSteps, len(receiveSteps)) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
this was testing the workflow idempotency, not the steps -- already tested elsewhere.
kraftp
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbos.Launch()recover workflows.Recv()