Workflow context getters #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work fine work 1 consumer <-> 1 producer, but set/get event accepts multiple consumers
…rns a workflow ID if any
maxdml
commented
Jul 24, 2025
Comment on lines
+782
to
+790
| // GetWorkflowID retrieves the workflow ID from the context if called within a DBOS workflow | ||
| func GetWorkflowID(ctx context.Context) (string, error) { | ||
| wfState, ok := ctx.Value(workflowStateKey).(*workflowState) | ||
| if !ok || wfState == nil { | ||
| return "", errors.New("not within a DBOS workflow context") | ||
| } | ||
| return wfState.workflowID, nil | ||
| } | ||
|
|
maxdml
commented
Jul 24, 2025
Comment on lines
+114
to
+127
| // Add custom migration table name to avoid conflicts with user migrations | ||
| // Parse the URL to properly determine where to add the query parameter | ||
| parsedURL, err := url.Parse(databaseURL) | ||
| if err != nil { | ||
| return newInitializationError(fmt.Sprintf("failed to parse database URL: %v", err)) | ||
| } | ||
|
|
||
| // Check if query parameters already exist | ||
| separator := "?" | ||
| if parsedURL.RawQuery != "" { | ||
| separator = "&" | ||
| } | ||
| databaseURL += separator + "x-migrations-table=" + _DBOS_MIGRATION_TABLE | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
dedicated migration table
kraftp
approved these changes
Jul 25, 2025
Member
kraftp
left a comment
kraftp
left a comment
There was a problem hiding this comment.
Looks good! There should also be a GetStepID
Collaborator
Author
Ha, yes. Will add in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbos_test.gofile