Conductor #73
Merged
Conductor #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pool, fix a small race in a test, remove unused code
maxdml
commented
Aug 25, 2025
Comment on lines
+716
to
+726
| // If no queue name was specified, only include workflows that have a queue name | ||
| var filteredWorkflows []WorkflowStatus | ||
| if req.Body.QueueName == nil { | ||
| for _, wf := range workflows { | ||
| if wf.QueueName != "" { | ||
| filteredWorkflows = append(filteredWorkflows, wf) | ||
| } | ||
| } | ||
| } else { | ||
| filteredWorkflows = workflows | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Note that I'll eventually add a filter that'll go down the SQL query (while maintaining the simplified listing UX)
kraftp
reviewed
Aug 27, 2025
dbos/dbos.go
Outdated
|
|
||
| // Initialize conductor if API key is provided | ||
| if config.ConductorAPIKey != "" { | ||
| if initExecutor.executorID == "local" { |
Member
There was a problem hiding this comment.
It's safer to just always generate a new ID here. Otherwise, there's potential for trouble--multiple servers sharing the same ID, for example.
kraftp
reviewed
Aug 27, 2025
| AppName: inputConfig.AppName, | ||
| Logger: inputConfig.Logger, | ||
| AdminServer: inputConfig.AdminServer, | ||
| DatabaseURL: inputConfig.DatabaseURL, |
Member
There was a problem hiding this comment.
Application version should also be an option here
Collaborator
Author
There was a problem hiding this comment.
I'm adding this and executor ID in a different PR
kraftp
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Conductor client.
Design
A conductor object is attached to a
DBOSContext. Its lifecycle management is done like other resources, insideDBOSContextLaunchandShutdownmethods.The conductor operates through two goroutines a "main" goroutine handling conductor messages, and a "ping" goroutine to keep the connection alive.
Main goroutine
The main goroutine is entirely responsible for managing the connection: whenever it detects it should connect to the server, it'll start a ping goroutine. Whenever it gets an error (e.g., reading on the websocket or sending a message), it will set the connection for closing.
Ping goroutine
The ping goutine will exit and signal the connection should be close if:
Others
ListWorkflows