Admin server port #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af-md
reviewed
Aug 31, 2025
maxdml
approved these changes
Sep 1, 2025
Collaborator
maxdml
left a comment
maxdml
left a comment
There was a problem hiding this comment.
Looks good, thank you for your contribution @shirzady1934! And @af-md for the review
maxdml
force-pushed
the
AdminServerPort
branch
from
da7cda8 to
a4ea915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced hard-coded port
3001with a configurableAdminServerPortfield inConfig.Updated
dbos.goto use the provided port (defaulting to 3001) and adjusted tests to use a custom port (38081).✅ All
TestAdminServercases now pass.