Skip to content

Commit 77f43ef

Browse files
authored
make is_deactivated a flag of AdminRequestHandler (#318)
New instances of `AdminRequestHandler` are created for every requests.
1 parent 68399d6 commit 77f43ef

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

dbos/_admin_server.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,10 @@ def stop(self) -> None:
4545

4646

4747
class AdminRequestHandler(BaseHTTPRequestHandler):
48+
is_deactivated = False
49+
4850
def __init__(self, dbos: DBOS, *args: Any, **kwargs: Any) -> None:
4951
self.dbos = dbos
50-
self.is_deactivated = False
5152
super().__init__(*args, **kwargs)
5253

5354
def _end_headers(self) -> None:
@@ -63,11 +64,11 @@ def do_GET(self) -> None:
6364
self._end_headers()
6465
self.wfile.write("healthy".encode("utf-8"))
6566
elif self.path == _deactivate_path:
66-
if not self.is_deactivated:
67+
if not AdminRequestHandler.is_deactivated:
6768
dbos_logger.info(
6869
f"Deactivating DBOS executor {GlobalParams.executor_id} with version {GlobalParams.app_version}. This executor will complete existing workflows but will not start new workflows."
6970
)
70-
self.is_deactivated = True
71+
AdminRequestHandler.is_deactivated = True
7172
# Stop all scheduled workflows, queues, and kafka loops
7273
for event in self.dbos.stop_events:
7374
event.set()

0 commit comments

Comments
 (0)