Consistent Sort Order (#207)

All list workflows command should sort in ascending order (most recently
started workflows last).

Author: kraftp

dbos/_sys_db.py

@@ -672,7 +672,7 @@ def get_workflow_inputs(
 
     def get_workflows(self, input: GetWorkflowsInput) -> GetWorkflowsOutput:
         query = sa.select(SystemSchema.workflow_status.c.workflow_uuid).order_by(
-            SystemSchema.workflow_status.c.created_at.desc()
+            SystemSchema.workflow_status.c.created_at.asc()
         )
         if input.name:
             query = query.where(SystemSchema.workflow_status.c.name == input.name)
@@ -718,7 +718,7 @@ def get_queued_workflows(
                 SystemSchema.workflow_queue.c.workflow_uuid
                 == SystemSchema.workflow_status.c.workflow_uuid,
             )
-            .order_by(SystemSchema.workflow_status.c.created_at.desc())
+            .order_by(SystemSchema.workflow_status.c.created_at.asc())
         )
 
         if input.get("name"):

tests/test_dbos.py

@@ -905,10 +905,10 @@ def test_send_recv_workflow(topic: str) -> str:
 
     wfs = dbos._sys_db.get_workflows(gwi)
     assert len(wfs.workflow_uuids) == 2
-    assert wfs.workflow_uuids[1] == dest_uuid
-    assert wfs.workflow_uuids[0] != dest_uuid
+    assert wfs.workflow_uuids[0] == dest_uuid
+    assert wfs.workflow_uuids[1] != dest_uuid
 
-    wfi = dbos._sys_db.get_workflow_info(wfs.workflow_uuids[0], False)
+    wfi = dbos._sys_db.get_workflow_info(wfs.workflow_uuids[1], False)
     assert wfi
     assert wfi["name"] == "<temp>.temp_send_workflow"
 

tests/test_workflow_cmds.py

@@ -245,8 +245,8 @@ def blocking_step(i: int) -> int:
         assert workflow.status == WorkflowStatusString.PENDING.value
         assert workflow.queue_name == queue.name
         assert workflow.input is not None
-        # Verify newest queue entries appear first
-        assert workflow.input["args"][0] == queued_steps - i - 1
+        # Verify oldest queue entries appear first
+        assert workflow.input["args"][0] == i
         assert workflow.output is None
         assert workflow.error is None
         assert "blocking_step" in workflow.workflowName