Better Validation (#495)

No need to require a host or username in database URL, both are optional
in the standard.

Also remove code that emits warnings if a function not marked as a
coroutine is called from an event loop, as it emits false positives when
using non-asyncio event loops.

Author: kraftp

dbos/_core.py

@@ -93,14 +93,6 @@
 DEBOUNCER_WORKFLOW_NAME = "_dbos_debouncer_workflow"
 
 
-def check_is_in_coroutine() -> bool:
-    try:
-        asyncio.get_running_loop()
-        return True
-    except RuntimeError:
-        return False
-
-
 class WorkflowHandleFuture(Generic[R]):
 
     def __init__(self, workflow_id: str, future: Future[R], dbos: "DBOS"):
@@ -856,11 +848,6 @@ def record_get_result(func: Callable[[], R]) -> R:
             dbos._sys_db.record_get_result(workflow_id, serialized_r, None)
             return r
 
-        if check_is_in_coroutine() and not inspect.iscoroutinefunction(func):
-            dbos_logger.warning(
-                f"Sync workflow ({get_dbos_func_name(func)}) shouldn't be invoked from within another async function. Define it as async or use asyncio.to_thread instead."
-            )
-
         outcome = (
             wfOutcome.wrap(init_wf, dbos=dbos)
             .also(DBOSAssumeRole(rr))
@@ -1046,10 +1033,6 @@ def wrapper(*args: Any, **kwargs: Any) -> Any:
                 assert (
                     ctx.is_workflow()
                 ), "Transactions must be called from within workflows"
-                if check_is_in_coroutine():
-                    dbos_logger.warning(
-                        f"Transaction function ({get_dbos_func_name(func)}) shouldn't be invoked from within another async function. Use asyncio.to_thread instead."
-                    )
                 with DBOSAssumeRole(rr):
                     return invoke_tx(*args, **kwargs)
             else:
@@ -1194,10 +1177,6 @@ def check_existing_result() -> Union[NoResult, R]:
 
         @wraps(func)
         def wrapper(*args: Any, **kwargs: Any) -> Any:
-            if check_is_in_coroutine() and not inspect.iscoroutinefunction(func):
-                dbos_logger.warning(
-                    f"Sync step ({get_dbos_func_name(func)}) shouldn't be invoked from within another async function. Define it as async or use asyncio.to_thread instead."
-                )
             # If the step is called from a workflow, run it as a step.
             # Otherwise, run it as a normal function.
             ctx = get_local_dbos_context()

dbos/_dbos_config.py

@@ -478,8 +478,6 @@ def is_valid_database_url(database_url: str) -> bool:
         return True
     url = make_url(database_url)
     required_fields = [
-        ("username", "Username must be specified in the connection URL"),
-        ("host", "Host must be specified in the connection URL"),
         ("database", "Database name must be specified in the connection URL"),
     ]
     for field_name, error_message in required_fields:

tests/test_config.py

@@ -610,24 +610,6 @@ def test_configure_db_engine_parameters_empty_user_kwargs():
 
 
 def test_process_config_with_wrong_db_url():
-    # Missing username
-    config: ConfigFile = {
-        "name": "some-app",
-        "database_url": "postgres://:password@h:1234/dbname",
-    }
-    with pytest.raises(DBOSInitializationError) as exc_info:
-        process_config(data=config)
-    assert "Username must be specified in the connection URL" in str(exc_info.value)
-
-    # Missing host
-    config: ConfigFile = {
-        "name": "some-app",
-        "database_url": "postgres://user:password@:1234/dbname",
-    }
-    with pytest.raises(DBOSInitializationError) as exc_info:
-        process_config(data=config)
-    assert "Host must be specified in the connection URL" in str(exc_info.value)
-
     # Missing dbname
     config: ConfigFile = {
         "name": "some-app",