Skip to content

Commit f1cff83

Browse files
authored
CLI Flags Cleanup (#443)
Make sure all flag short forms are unique.
1 parent c560d0b commit f1cff83

File tree

2 files changed

+14
-24
lines changed

2 files changed

+14
-24
lines changed

.github/workflows/unit-test.yml

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,33 +40,23 @@ jobs:
4040
ports:
4141
# Maps tcp port 5432 on service container to the host
4242
- 5432:5432
43-
# Zookeeper service container (required by Kafka)
44-
zookeeper:
45-
image: bitnami/zookeeper
46-
ports:
47-
- 2181:2181
48-
env:
49-
ALLOW_ANONYMOUS_LOGIN: yes
50-
options: >-
51-
--health-cmd "echo mntr | nc -w 2 -q 2 localhost 2181"
52-
--health-interval 10s
53-
--health-timeout 5s
54-
--health-retries 5
5543
# Kafka service container
5644
kafka:
57-
image: bitnami/kafka:3.9.0
45+
image: apache/kafka:latest
5846
ports:
5947
- 9092:9092
60-
options: >-
61-
--health-cmd "kafka-broker-api-versions.sh --version"
62-
--health-interval 10s
63-
--health-timeout 5s
64-
--health-retries 5
6548
env:
66-
KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181
67-
ALLOW_PLAINTEXT_LISTENER: yes
68-
KAFKA_CFG_LISTENERS: PLAINTEXT://:9092
69-
KAFKA_CFG_ADVERTISED_LISTENERS: PLAINTEXT://127.0.0.1:9092
49+
KAFKA_NODE_ID: 1
50+
KAFKA_LISTENERS: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
51+
KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://127.0.0.1:9092
52+
KAFKA_PROCESS_ROLES: broker,controller
53+
KAFKA_CONTROLLER_QUORUM_VOTERS: 1@localhost:9093
54+
KAFKA_CONTROLLER_LISTENER_NAMES: CONTROLLER
55+
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT
56+
KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
57+
KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
58+
KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1
59+
CLUSTER_ID: MkU3OEVBNTcwNTJENDM2Qk
7060

7161
steps:
7262
- uses: actions/checkout@v4

dbos/cli/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ def list(
427427
typing.Optional[str],
428428
typer.Option(
429429
"--start-time",
430-
"-s",
430+
"-t",
431431
help="Retrieve workflows starting after this timestamp (ISO 8601 format)",
432432
),
433433
] = None,
@@ -765,7 +765,7 @@ def list_queue(
765765
typing.Optional[str],
766766
typer.Option(
767767
"--start-time",
768-
"-s",
768+
"-t",
769769
help="Retrieve functions starting after this timestamp (ISO 8601 format)",
770770
),
771771
] = None,

0 commit comments

Comments
 (0)