(fix go/snowflake) fix deprecated usage of client session keep alive (#100)

Author: xuliangs

go/adbc/driver/snowflake/driver.go

@@ -92,7 +92,8 @@ const (
 	OptionAuthToken = "adbc.snowflake.sql.client_option.auth_token"
 	// specify the OKTAUrl to use for OKTA Authentication
 	OptionAuthOktaUrl = "adbc.snowflake.sql.client_option.okta_url"
-	// enable the session to persist even after the connection is closed
+	// Enable a heartbeat in the background to keep the connection session alive.
+	// Uses the client_session_keep_alive DSN parameter internally.
 	OptionKeepSessionAlive = "adbc.snowflake.sql.client_option.keep_session_alive"
 	// specify the RSA private key to use to sign the JWT
 	// this should point to a file containing a PKCS1 private key to be

go/adbc/driver/snowflake/snowflake_database.go

@@ -135,7 +135,7 @@ func (d *databaseImpl) GetOption(key string) (string, error) {
 	case OptionAuthOktaUrl:
 		return d.cfg.OktaURL.String(), nil
 	case OptionKeepSessionAlive:
-		if d.cfg.KeepSessionAlive {
+		if v, ok := d.cfg.Params["client_session_keep_alive"]; ok && v != nil && strings.ToLower(*v) == adbc.OptionValueEnabled {
 			return adbc.OptionValueEnabled, nil
 		}
 		return adbc.OptionValueDisabled, nil
@@ -362,12 +362,14 @@ func (d *databaseImpl) SetOptionInternal(k string, v string, cnOptions *map[stri
 	case OptionKeepSessionAlive:
 		switch v {
 		case adbc.OptionValueEnabled:
-			d.cfg.KeepSessionAlive = true
+			trueValue := adbc.OptionValueEnabled
+			d.cfg.Params["client_session_keep_alive"] = &trueValue
 		case adbc.OptionValueDisabled:
-			d.cfg.KeepSessionAlive = false
+			falseValue := adbc.OptionValueDisabled
+			d.cfg.Params["client_session_keep_alive"] = &falseValue
 		default:
 			return adbc.Error{
-				Msg:  fmt.Sprintf("Invalid value for database option '%s': '%s'", OptionSSLSkipVerify, v),
+				Msg:  fmt.Sprintf("Invalid value for database option '%s': '%s'", OptionKeepSessionAlive, v),
 				Code: adbc.StatusInvalidArgument,
 			}
 		}