Adap 1032/fix redshift incremental merge ddl (#1121)

Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Colin Rogers <[email protected]>
Co-authored-by: Colin <[email protected]>

Author: 3 people

dbt-redshift/.changes/unreleased/Fixes-20250605-145421.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: fix macro naming get_delete_insert_merge_sql
+time: 2025-06-05T14:54:21.254391-07:00
+custom:
+  Author: VersusFacit
+  Issue: "1032"

dbt-redshift/src/dbt/include/redshift/macros/materializations/incremental_delete_insert.sql

@@ -1,4 +1,4 @@
-{% macro default__get_delete_insert_merge_sql(target, source, unique_key, dest_columns, incremental_predicates) -%}
+{% macro redshift__get_delete_insert_merge_sql(target, source, unique_key, dest_columns, incremental_predicates) -%}
     {%- set predicates = _update_predicates(target, incremental_predicates) -%}
 
     {%- set dest_cols_csv = get_quoted_csv(dest_columns | map(attribute="name")) -%}

dbt-redshift/tests/functional/adapter/incremental/test_delete_insert_merge.py

@@ -0,0 +1,46 @@
+import json
+import os
+
+import pytest
+
+from dbt.tests.util import run_dbt, run_dbt_and_capture
+
+
+MODEL_SQL = """
+{{ config(
+    materialized='incremental',
+    unique_key='id'
+) }}
+
+SELECT 1 AS id, 'foo' AS value
+"""
+EXPECTED_SQL_FRAGMENTS = [
+    "delete from",
+    "using",
+    "insert into",
+]
+UNEXPECTED_SQL_PATTERN = r"delete from\s+\{\{\s*this\s*\}\}\s+AS\s+\w+"
+
+
+@pytest.fixture(scope="class")
+def models():
+    return {"model.sql": MODEL_SQL}
+
+
+def test_delete_insert_merge(project):
+    """
+    Addresses https://github.com/dbt-labs/dbt-adapters/issues/1032
+    """
+    # run once to create the base table
+    run_dbt(["run"])
+
+    # run a second time to trigger the incremental load
+    results, logs = run_dbt_and_capture(["--debug", "run"])
+
+    # make sure we did something
+    assert len(results) == 1
+
+    # check the logs for expected values, or lack thereof
+    for fragment in EXPECTED_SQL_FRAGMENTS:
+        assert fragment in logs
+    assert UNEXPECTED_SQL_PATTERN not in logs