move protos into external dependency (#1087)

Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Colin Rogers <[email protected]>

Author: 3 people

.pre-commit-config.yaml

@@ -26,14 +26,13 @@ repos:
         -   --target-version=py310
         -   --target-version=py311
         -   --target-version=py312
-        -   --force-exclude=dbt-adapters/src/dbt/adapters/events/adapter_types_pb2.py
         additional_dependencies: [flaky]
 
 -   repo: https://github.com/pycqa/flake8
     rev: 7.1.1
     hooks:
     -   id: flake8
-        exclude: dbt-adapters/src/dbt/adapters/events/adapter_types_pb2.py|dbt-adapters/tests/|dbt-spark/tests/|dbt-bigquery/tests/|dbt-redshift/tests|dbt-postgres/tests|dbt-snowflake/tests
+        exclude: dbt-adapters/tests/|dbt-spark/tests/|dbt-bigquery/tests/|dbt-redshift/tests|dbt-postgres/tests|dbt-snowflake/tests
         args:
         -   --max-line-length=99
         -   --select=E,F,W

dbt-adapters/pyproject.toml

@@ -28,6 +28,7 @@ classifiers = [
 ]
 dependencies = [
     "dbt-common>=1.13,<2.0",
+    "dbt-protos>=1.0.291,<2.0",
     "pytz>=2015.7",
     # installed via dbt-common but used directly
     "agate>=1.0,<2.0",

dbt-adapters/src/dbt/adapters/events/README.md

@@ -8,13 +8,7 @@ The event module provides types that represent what is happening in dbt in `even
 When events are processed via `fire_event`, nearly everything is logged. Whether or not the user has enabled the debug flag, all debug messages are still logged to the file. However, some events are particularly time consuming to construct because they return a huge amount of data. Today, the only messages in this category are cache events and are only logged if the `--log-cache-events` flag is on. This is important because these messages should not be created unless they are going to be logged, because they cause a noticable performance degredation. These events use a "fire_event_if" functions.
 
 # Adding a New Event
-* Add a new message in types.proto, and a second message with the same name + "Msg". The "Msg" message should have two fields, an "info" field of EventInfo, and a "data" field referring to the message name without "Msg"
-* run the protoc compiler to update adapter_types_pb2.py:   make adapter_proto_types
-* Add a wrapping class in core/dbt/adapters/event/types.py with a Level superclass  plus code and message methods
-
-We have switched from using betterproto to using google protobuf, because of a lack of support for Struct fields in betterproto.
-
-The google protobuf interface is janky and very much non-Pythonic. The "generated" classes in types_pb2.py do not resemble regular Python classes. They do not have normal constructors; they can only be constructed empty. They can be "filled" by setting fields individually or using a json_format method like ParseDict.  We have wrapped the logging events with a class (in types.py) which allows using a constructor -- keywords only, no positional parameters.
+All protos have been moved into the central protos repository. To edit an event proto, edit https://github.com/dbt-labs/proto-python-public or open an issue on that repository.
 
 ## Required for Every Event