Skip to content

Conversation

@dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jun 23, 2025

resolves #254

Problem

Macros that generate unit tests are capitalizing non-quoted column names for Snowflake.

Solution

Lowercase all column names by default.
Defer to #255 to handle case-sensitive column names.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the README.md (if applicable)

@dbeatty10
Copy link
Contributor Author

dbeatty10 commented Jun 24, 2025

I don't understand why, but I'm getting different results for tests running in CircleCI vs. GitHub Actions:

CircleCI:

image

GitHub Actions:

image

There aren't any caches here or here:

image

@dbeatty10
Copy link
Contributor Author

When I ran the integration changes locally without the change in this PR, they failed, But they succeeded once I made this change. So the GitHub Actions failure is an anomaly out of those 3 different methods to execute the integration tests. Since
we want this change, I'm going to merge anyways even I though I haven't figured out reason for the GHA failures 🤷.

@dbeatty10 dbeatty10 marked this pull request as ready for review June 24, 2025 00:34
@dbeatty10 dbeatty10 requested a review from a team as a code owner June 24, 2025 00:35
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 24, 2025
@dbeatty10 dbeatty10 merged commit 474f7a1 into main Jun 24, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Macros that generate unit tests are capitalizing non-quoted column names for Snowflake

2 participants