Avoid redundant node patch removal during partial parsing (#11887)

* Avoid redundant node patch removal during partial parsing

* Changelog entry

---------

Co-authored-by: Doug Beatty <[email protected]>

Author: wircho

.changes/unreleased/Fixes-20250804-074006.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Avoid redundant node patch removal during partial parsing
+time: 2025-08-04T07:40:06.993913-06:00
+custom:
+    Author: wircho
+    Issue: "11886"

core/dbt/parser/partial.py

@@ -870,7 +870,10 @@ def delete_schema_mssa_links(self, schema_file, dict_key, elem) -> None:
                     if node.is_versioned or elem.get("versions"):
                         self.schedule_referencing_nodes_for_parsing(node.unique_id)
             # remove from patches
-            schema_file.node_patches.remove(elem_unique_id)
+            # For versioned models, the schedule_referencing_nodes_for_parsing call above
+            # could have caused a recursive visit to this file.
+            if elem_unique_id in schema_file.node_patches:
+                schema_file.node_patches.remove(elem_unique_id)
 
         # for models, seeds, snapshots (not analyses)
         if dict_key in ["models", "seeds", "snapshots"]: