Ensure build_after is present in model freshness in parsing, otherwise skip freshness definition (#11711)

* Ensure `build_after` is present in model freshness in parsing, otherwise skip freshness definition

* add freshness model config test

* add changelog

---------

Co-authored-by: Colin <[email protected]>

Author: QMalcolm

.changes/unreleased/Fixes-20250605-110645.yaml

@@ -0,0 +1,7 @@
+kind: Fixes
+body: Ensure build_after is present in model freshness in parsing, otherwise skip
+  freshness definition
+time: 2025-06-05T11:06:45.329942-07:00
+custom:
+  Author: QMalcolm
+  Issue: "11709"

core/dbt/contracts/graph/unparsed.py

@@ -18,7 +18,6 @@
     MacroArgument,
     MaturityType,
     MeasureAggregationParameters,
-    ModelFreshness,
     NodeVersion,
     Owner,
     Quoting,
@@ -226,7 +225,7 @@ class UnparsedModelUpdate(UnparsedNodeUpdate):
     versions: Sequence[UnparsedVersion] = field(default_factory=list)
     deprecation_date: Optional[datetime.datetime] = None
     time_spine: Optional[TimeSpine] = None
-    freshness: Optional[ModelFreshness] = None
+    freshness: Optional[Dict[str, Any]] = None
 
     def __post_init__(self) -> None:
         if self.latest_version:

core/dbt/parser/schemas.py

@@ -789,7 +789,7 @@ def parse_patch(self, block: TargetBlock[NodeTarget], refs: ParserRef) -> None:
                 project_freshness_dict = self.project.models.get("+freshness", None)
                 project_freshness = (
                     ModelFreshness.from_dict(project_freshness_dict)
-                    if project_freshness_dict
+                    if project_freshness_dict and "build_after" in project_freshness_dict
                     else None
                 )
             except ValueError:
@@ -801,11 +801,18 @@ def parse_patch(self, block: TargetBlock[NodeTarget], refs: ParserRef) -> None:
                 )
                 project_freshness = None
 
-            model_freshness = block.target.freshness or None
+            model_freshness_dict = block.target.freshness or None
+            model_freshness = (
+                ModelFreshness.from_dict(model_freshness_dict)
+                if model_freshness_dict and "build_after" in model_freshness_dict
+                else None
+            )
 
             config_freshness_dict = block.target.config.get("freshness", None)
             config_freshness = (
-                ModelFreshness.from_dict(config_freshness_dict) if config_freshness_dict else None
+                ModelFreshness.from_dict(config_freshness_dict)
+                if config_freshness_dict and "build_after" in config_freshness_dict
+                else None
             )
             freshness = merge_model_freshness(project_freshness, model_freshness, config_freshness)
 

tests/functional/model_config/test_freshness_config.py

@@ -0,0 +1,82 @@
+import pytest
+
+from dbt.tests.util import run_dbt
+
+# Seed data for source tables
+seeds__source_table_csv = """id,_loaded_at
+1,2024-03-20 00:00:00
+2,2024-03-20 00:00:00
+3,2024-03-20 00:00:00
+"""
+
+
+models__no_freshness_sql = """
+select 1 as id
+"""
+
+# Scenario 2: Model freshness defined with just model freshness spec
+models__model_freshness_schema_yml = """
+version: 2
+
+sources:
+  - name: my_source
+    database: "{{ target.database }}"
+    schema: "{{ target.schema }}"
+    freshness:
+      warn_after: {count: 24, period: hour}
+      error_after: {count: 48, period: hour}
+    loaded_at_field: _loaded_at
+    tables:
+      - name: source_table
+        identifier: source_table
+
+models:
+  - name: model_a
+    description: Model with no freshness defined
+  - name: model_b
+    description: Model with only model freshness defined
+    freshness:
+      build_after:
+        count: 1
+        period: day
+        updates_on: all
+  - name: model_c
+    description: Model with only source freshness defined
+    freshness:
+      warn_after: {count: 24, period: hour}
+      error_after: {count: 48, period: hour}
+    loaded_at_field: _loaded_at
+    tables:
+      - name: source_table
+        identifier: source_table
+"""
+
+models__model_freshness_sql = """
+select 1 as id
+"""
+
+models__source_freshness_sql = """
+select * from {{ source('my_source', 'source_table') }}
+"""
+
+models__both_freshness_sql = """
+select * from {{ source('my_source', 'source_table') }}
+"""
+
+
+class TestModelFreshnessConfig:
+
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": models__model_freshness_schema_yml,
+            "model_a.sql": models__no_freshness_sql,
+            "model_b.sql": models__model_freshness_sql,
+            "model_c.sql": models__source_freshness_sql,
+            "model_d.sql": models__both_freshness_sql,
+        }
+
+    def test_model_freshness_configs(self, project):
+        run_dbt(["parse"])
+        compile_results = run_dbt(["compile"])
+        assert len(compile_results) == 4  # All 4 models compiled successfully