Fix legacy time spine deprecation warning logic (#12018)

Author: courtneyholcomb

.changes/unreleased/Fixes-20250915-152227.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fixes a bug in the logic for legacy time spine deprecation warnings.
+time: 2025-09-15T15:22:27.791819-07:00
+custom:
+  Author: courtneyholcomb
+  Issue: "11690"

core/dbt/contracts/graph/semantic_manifest.py

@@ -127,7 +127,6 @@ def write_json_to_file(self, file_path: str):
     def _get_pydantic_semantic_manifest(self) -> PydanticSemanticManifest:
         pydantic_time_spines: List[PydanticTimeSpine] = []
         minimum_time_spine_granularity: Optional[TimeGranularity] = None
-        has_legacy_time_spine_with_config: bool = False
         for node in self.manifest.nodes.values():
             if not (isinstance(node, ModelNode) and node.time_spine):
                 continue
@@ -167,8 +166,6 @@ def _get_pydantic_semantic_manifest(self) -> PydanticSemanticManifest:
                 ],
             )
             pydantic_time_spines.append(pydantic_time_spine)
-            if pydantic_time_spine.node_relation.relation_name == LEGACY_TIME_SPINE_MODEL_NAME:
-                has_legacy_time_spine_with_config = True
             if (
                 not minimum_time_spine_granularity
                 or standard_granularity_column.granularity.to_int()
@@ -196,18 +193,18 @@ def _get_pydantic_semantic_manifest(self) -> PydanticSemanticManifest:
                 PydanticSavedQuery.parse_obj(saved_query.to_dict())
             )
 
+        legacy_time_spine_model: Optional[ModelNode] = None
         if self.manifest.semantic_models:
-            if not has_legacy_time_spine_with_config:
-                legacy_time_spine_model = self.manifest.ref_lookup.find(
-                    LEGACY_TIME_SPINE_MODEL_NAME, None, None, self.manifest
-                )
-                if legacy_time_spine_model:
-                    if (
-                        not minimum_time_spine_granularity
-                        or LEGACY_TIME_SPINE_GRANULARITY.to_int()
-                        < minimum_time_spine_granularity.to_int()
-                    ):
-                        minimum_time_spine_granularity = LEGACY_TIME_SPINE_GRANULARITY
+            legacy_time_spine_model = self.manifest.ref_lookup.find(
+                LEGACY_TIME_SPINE_MODEL_NAME, None, None, self.manifest
+            )
+            if legacy_time_spine_model:
+                if (
+                    not minimum_time_spine_granularity
+                    or LEGACY_TIME_SPINE_GRANULARITY.to_int()
+                    < minimum_time_spine_granularity.to_int()
+                ):
+                    minimum_time_spine_granularity = LEGACY_TIME_SPINE_GRANULARITY
 
             # If no time spines have been configured at DAY or smaller AND legacy time spine model does not exist, error.
             if (
@@ -221,8 +218,8 @@ def _get_pydantic_semantic_manifest(self) -> PydanticSemanticManifest:
                     "(https://docs.getdbt.com/docs/build/metricflow-time-spine)."
                 )
 
-            # For backward compatibility: if legacy time spine exists, include it in the manifest.
-            if legacy_time_spine_model:
+            # For backward compatibility: if legacy time spine exists without config, include it in the manifest.
+            if legacy_time_spine_model and legacy_time_spine_model.time_spine is None:
                 legacy_time_spine = LegacyTimeSpine(
                     location=legacy_time_spine_model.relation_name,
                     column_name="date_day",

tests/functional/time_spines/test_time_spines.py

@@ -87,12 +87,6 @@ def test_time_spines(self, project):
         semantic_manifest = SemanticManifest(manifest)
         assert semantic_manifest.validate()
         project_config = semantic_manifest._get_pydantic_semantic_manifest().project_configuration
-        # Legacy config
-        assert len(project_config.time_spine_table_configurations) == 1
-        legacy_time_spine_config = project_config.time_spine_table_configurations[0]
-        assert legacy_time_spine_config.column_name == day_column_name
-        assert legacy_time_spine_config.location.replace('"', "").split(".")[-1] == day_model_name
-        assert legacy_time_spine_config.grain == TimeGranularity.DAY
         # Current configs
         assert len(project_config.time_spines) == 2
         sl_time_spine_aliases: Set[str] = set()

tests/unit/contracts/graph/test_semantic_manifest.py

@@ -3,13 +3,16 @@
 import pytest
 
 from core.dbt.contracts.graph.manifest import Manifest
-from core.dbt.contracts.graph.nodes import Metric, ModelNode
 from dbt.artifacts.resources.types import NodeType
 from dbt.artifacts.resources.v1.metric import (
     CumulativeTypeParams,
     MetricTimeWindow,
     MetricTypeParams,
 )
+from dbt.artifacts.resources.v1.model import ModelConfig, TimeSpine
+from dbt.constants import LEGACY_TIME_SPINE_MODEL_NAME
+from dbt.contracts.files import FileHash
+from dbt.contracts.graph.nodes import ColumnInfo, DependsOn, Metric, ModelNode
 from dbt.contracts.graph.semantic_manifest import SemanticManifest
 from dbt_semantic_interfaces.type_enums import TimeGranularity
 from dbt_semantic_interfaces.type_enums.metric_type import MetricType
@@ -55,6 +58,57 @@ def test_require_yaml_configuration_for_mf_time_spines(
             assert sm_manifest.validate()
             assert patched_deprecations.warn.call_count == 1
 
+    def test_metricflow_time_spine_non_day_grain_deprecation_warning(
+        self, manifest: Manifest, metricflow_time_spine_model: ModelNode
+    ):
+        """Test that a metricflow_time_spine with non-day grain does not trigger deprecation warning."""
+        # Create a metricflow_time_spine model with HOUR granularity
+        metricflow_time_spine_hour = ModelNode(
+            name=LEGACY_TIME_SPINE_MODEL_NAME,
+            database="dbt",
+            schema="analytics",
+            alias=LEGACY_TIME_SPINE_MODEL_NAME,
+            resource_type=NodeType.Model,
+            unique_id="model.test.metricflow_time_spine",
+            fqn=["test", "metricflow_time_spine"],
+            package_name="test",
+            refs=[],
+            sources=[],
+            metrics=[],
+            depends_on=DependsOn(),
+            config=ModelConfig(),
+            tags=[],
+            path="metricflow_time_spine.sql",
+            original_file_path="metricflow_time_spine.sql",
+            meta={},
+            language="sql",
+            raw_code="SELECT DATEADD(hour, ROW_NUMBER() OVER (ORDER BY 1), '2020-01-01'::timestamp) as ts_hour",
+            checksum=FileHash.empty(),
+            relation_name="",
+            columns={
+                "ts_hour": ColumnInfo(
+                    name="ts_hour",
+                    description="",
+                    meta={},
+                    data_type="timestamp",
+                    constraints=[],
+                    quote=None,
+                    tags=[],
+                    granularity=TimeGranularity.HOUR,
+                )
+            },
+            time_spine=TimeSpine(standard_granularity_column="ts_hour"),
+        )
+
+        with patch("dbt.contracts.graph.semantic_manifest.get_flags") as patched_get_flags, patch(
+            "dbt.contracts.graph.semantic_manifest.deprecations"
+        ) as patched_deprecations:
+            patched_get_flags.return_value.require_yaml_configuration_for_mf_time_spines = False
+            manifest.nodes[metricflow_time_spine_hour.unique_id] = metricflow_time_spine_hour
+            sm_manifest = SemanticManifest(manifest)
+            assert sm_manifest.validate()
+            assert patched_deprecations.warn.call_count == 0
+
     @pytest.mark.parametrize(
         "metric_type_params, num_warns, should_error, flag_value",
         [

tests/unit/utils/manifest.py

@@ -19,6 +19,12 @@
 )
 from dbt.artifacts.resources.types import ModelLanguage
 from dbt.artifacts.resources.v1.model import ModelConfig
+from dbt.artifacts.resources.v1.semantic_model import (
+    Defaults,
+    Dimension,
+    DimensionTypeParams,
+    Measure,
+)
 from dbt.contracts.files import AnySourceFile, FileHash
 from dbt.contracts.graph.manifest import Manifest, ManifestMetadata
 from dbt.contracts.graph.nodes import (
@@ -44,7 +50,12 @@
 )
 from dbt.contracts.graph.unparsed import UnitTestInputFixture, UnitTestOutputFixture
 from dbt.node_types import NodeType
-from dbt_semantic_interfaces.type_enums import MetricType
+from dbt_semantic_interfaces.type_enums import (
+    AggregationType,
+    DimensionType,
+    MetricType,
+    TimeGranularity,
+)
 
 
 def make_model(
@@ -485,6 +496,21 @@ def make_semantic_model(
         unique_id=f"semantic_model.{pkg}.{name}",
         original_file_path=path,
         fqn=[pkg, "semantic_models", name],
+        defaults=Defaults(agg_time_dimension="created_at"),
+        dimensions=[
+            Dimension(
+                name="created_at",
+                type=DimensionType.TIME,
+                type_params=DimensionTypeParams(time_granularity=TimeGranularity.DAY),
+            )
+        ],
+        measures=[
+            Measure(
+                name="a_measure",
+                agg=AggregationType.COUNT,
+                expr="1",
+            )
+        ],
     )