Add retry to macos postgres setup (#11432)

* Retry macos postgres setup

* Retry command instead of step

* Use setup_db.sh

* Simplify macos postgres setup

Author: aranke

.github/actions/setup-postgres-macos/action.yml

@@ -284,7 +284,12 @@ jobs:
 
       - name: Set up postgres (macos)
         if: runner.os == 'macOS'
-        uses: ./.github/actions/setup-postgres-macos
+
+        uses: nick-fields/retry@v3
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          command: ./test/setup_db.sh
 
       - name: Set up postgres (windows)
         if: runner.os == 'Windows'

.github/actions/setup-postgres-macos/setup_db.sh

@@ -99,9 +99,13 @@ jobs:
         run: make setup-db
 
         # mac and windows don't use make due to limitations with docker with those runners in GitHub
-      - name: "Set up postgres (macos)"
-        if: inputs.os == 'macos-14'
-        uses: ./.github/actions/setup-postgres-macos
+      - name: Set up postgres (macos)
+        if: runner.os == 'macOS'
+        uses: nick-fields/retry@v3
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          command: ./test/setup_db.sh
 
       - name: "Set up postgres (windows)"
         if: inputs.os == 'windows-latest'

.github/workflows/main.yml

@@ -1,5 +1,33 @@
 #!/bin/bash
 set -x
+
+brew install postgresql@16
+brew link postgresql@16 --force
+
+# Add the services tap and ensure PATH is updated
+brew tap homebrew/services
+export PATH="/opt/homebrew/opt/postgresql@16/bin:$PATH"
+
+# Start PostgreSQL using the full command instead of brew services
+pg_ctl -D /opt/homebrew/var/postgresql@16 start
+
+echo "Check PostgreSQL service is running"
+i=10
+COMMAND='pg_isready'
+while [ $i -gt -1 ]; do
+    if [ $i == 0 ]; then
+        echo "PostgreSQL service not ready, all attempts exhausted"
+        exit 1
+    fi
+    echo "Check PostgreSQL service status"
+    eval $COMMAND && break
+    echo "PostgreSQL service not ready, wait 10 more sec, attempts left: $i"
+    sleep 10
+    ((i--))
+done
+
+createuser -s postgres
+
 env | grep '^PG'
 
 # If you want to run this script for your own postgresql (run with