Simplify logic (#11678)

Author: aranke

.changes/unreleased/Under the Hood-20250527-162136.yaml

@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Prevent overcounting PropertyMovedToConfigDeprecation for source freshness
+time: 2025-05-27T16:21:36.551426+01:00
+custom:
+    Author: aranke
+    Issue: "11660"

core/dbt/parser/sources.py

@@ -54,6 +54,7 @@ def __init__(
         self.generic_test_parsers: Dict[str, SchemaGenericTestParser] = {}
         self.patches_used: Dict[SourceKey, Set[str]] = {}
         self.sources: Dict[str, SourceDefinition] = {}
+        self._deprecations: Set[Any] = set()
 
     # This method calls the 'parse_source' method which takes
     # the UnpatchedSourceDefinitions in the manifest and combines them
@@ -169,24 +170,26 @@ def parse_source(self, target: UnpatchedSourceDefinition) -> SourceDefinition:
             project_freshness = None
 
         source_freshness = source.freshness
-        if source_freshness:
+        if source_freshness and (target.path, source.name) not in self._deprecations:
             deprecations.warn(
                 "property-moved-to-config-deprecation",
                 key="freshness",
                 file=target.path,
                 key_path=source.name,
             )
+            self._deprecations.add((target.path, source.name))
 
         source_config_freshness = FreshnessThreshold.from_dict(source.config.get("freshness", {}))
 
         table_freshness = table.freshness
-        if table_freshness:
+        if table_freshness and (target.path, table.name) not in self._deprecations:
             deprecations.warn(
                 "property-moved-to-config-deprecation",
                 key="freshness",
                 file=target.path,
                 key_path=table.name,
             )
+            self._deprecations.add((target.path, table.name))
 
         table_config_freshness = FreshnessThreshold.from_dict(table.config.get("freshness", {}))
         freshness = merge_source_freshness(