COPYBARA PUBLIC PR: #145 (#3829)

* COPYBARA PUBLIC PR: https://github.com/dbt-labs/dbt-fusion/145
Make modules.pytz.timezone compatible with dbt-core

GitOrigin-RevId: 7fda2a1

* Fixing build

* Added changelog. Trying to fix build.

* Reset Cargo.lock and update it again

* Declare chrono-tz case-insensitive feature workspace-wide

chrono-tz & chrono-tz-build makes incorrect assumptions about how cargo
works, leading to compile time failures.
This can happen when something enables chrono-tz-build crate > case-insensitive feature,
without enabling chrono-tz crate > case-insensitive feature.

* Added changelog

* Added changelog

---------

Co-authored-by: Tai Le Manh <[email protected]>
Co-authored-by: TIHan <[email protected]>
Co-authored-by: Piotr Findeisen <[email protected]>
GitOrigin-RevId: 20df6e9ab7ec01ec62a9ff52db45aafc3d22bc33

Author: 4 people

.changes/unreleased/Fixes-20250618-092735.yaml

@@ -0,0 +1,3 @@
+kind: Fixes
+body: Make modules.pytz.timezone compatible with dbt-core by tlm365.
+time: 2025-06-18T09:27:35.642874-07:00

Cargo.toml

@@ -301,7 +301,7 @@ base64 = "0.22.1"
 bigdecimal = "0.4.7"
 blake3 = "1.5.0"
 chrono = { version = "0.4.31", features = ["std", "clock", "serde"] }
-chrono-tz = { version = "0.10.1" }
+chrono-tz = { version = "0.10.1", features = ["case-insensitive"] }
 clap = { version = "4.4.4", features = ["derive"] }
 counter = "0.6.0"
 dashmap = "6.1.0"

crates/dbt-jinja/minijinja-contrib/Cargo.toml

@@ -31,7 +31,7 @@ unicode_wordwrap = [
 
 [dependencies]
 chrono = { version = "0.4.26", features = ["serde"] }
-chrono-tz = { version = "0.10.1" }
+chrono-tz = { workspace = true }
 fancy-regex = { workspace = true }
 iana-time-zone = { workspace = true }
 minijinja = { workspace = true }

crates/dbt-jinja/minijinja-contrib/src/modules/pytz.rs

@@ -3,7 +3,6 @@ use chrono_tz::Tz;
 use minijinja::{Error, ErrorKind, Value};
 use std::collections::BTreeMap;
 use std::fmt;
-use std::str::FromStr;
 use std::sync::Arc;
 
 /// A Python-like "pytz" timezone object that wraps a `chrono_tz::Tz`.
@@ -81,7 +80,7 @@ fn timezone(args: &[Value]) -> Result<Value, Error> {
     })?;
 
     // Try to parse it as a Chrono Tz.
-    match Tz::from_str(tz_name) {
+    match Tz::from_str_insensitive(tz_name) {
         Ok(tz) => Ok(Value::from_object(PytzTimezone::new(tz))),
         Err(_) => Err(Error::new(
             ErrorKind::InvalidArgument,
@@ -116,3 +115,42 @@ impl minijinja::value::Object for PytzTimezone {
         write!(f, "{}", self.tz)
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use crate::modules::pytz::{timezone, PytzTimezone};
+    use chrono_tz::Tz;
+    use minijinja::Value;
+
+    #[test]
+    fn test_valid_timezone_utc() {
+        let args = vec![Value::from("UTC")];
+        let result = timezone(&args);
+        assert!(result.is_ok());
+
+        let actual = result.unwrap();
+        let expected = Value::from_object(PytzTimezone::new(chrono_tz::UTC));
+        assert_eq!(actual, expected);
+    }
+
+    #[test]
+    fn test_valid_timezone_case_insensitive() {
+        let args = vec![Value::from("asia/ho_chi_minh")];
+        let result = timezone(&args);
+        assert!(result.is_ok());
+
+        let actual = result.unwrap();
+        let expected = Value::from_object(PytzTimezone::new(Tz::Asia__Ho_Chi_Minh));
+        assert_eq!(actual, expected);
+    }
+
+    #[test]
+    fn test_invalid_timezone() {
+        let args = vec![Value::from("Invalid/Zone")];
+        let result = timezone(&args);
+        assert!(result.is_err());
+
+        let err = result.unwrap_err();
+        assert!(err.to_string().contains("Invalid timezone name"));
+    }
+}