Reverted dbt-labs/fs#3829 as there is an issue with chrono-tz referencing uncased (#4143)

* Reverted #145 as there is an issue with chrono-tz referencing uncased

* Added changelog

* Fix consistency

GitOrigin-RevId: 6e1f6ae9728f12383ae75d2fe7f373e11d3e6710

Author: TIHan

.changes/unreleased/Fixes-20250625-135738.yaml

@@ -0,0 +1,3 @@
+kind: Fixes
+body: Reverted timezone compatibility change due to 'chrono-tz' crate having an issue referencing 'uncased' crate
+time: 2025-06-25T13:57:38.676795-07:00

Cargo.toml

@@ -301,7 +301,7 @@ base64 = "0.22.1"
 bigdecimal = "0.4.7"
 blake3 = "1.5.0"
 chrono = { version = "0.4.31", features = ["std", "clock", "serde"] }
-chrono-tz = { version = "0.10", features = ["case-insensitive"] }
+chrono-tz = { version = "0.10" }
 clap = { version = "4.4.4", features = ["derive"] }
 counter = "0.6.0"
 dashmap = "6.1.0"
@@ -345,8 +345,8 @@ tonic-build = "0.11.0"
 jsonschema-valid = "0.5.2"
 
 # phf
-phf = { version = "0.11", features = ["uncased"] }
-phf_shared = { version = "0.11", features = ["uncased"] }
+phf = { version = "0.11" }
+phf_shared = { version = "0.11" }
 
 # error handling
 anyhow = { version = "1.0.74" }

crates/dbt-jinja/Cargo.lock.msrv

@@ -3,6 +3,7 @@ use chrono_tz::Tz;
 use minijinja::{Error, ErrorKind, Value};
 use std::collections::BTreeMap;
 use std::fmt;
+use std::str::FromStr;
 use std::sync::Arc;
 
 /// A Python-like "pytz" timezone object that wraps a `chrono_tz::Tz`.
@@ -80,7 +81,7 @@ fn timezone(args: &[Value]) -> Result<Value, Error> {
     })?;
 
     // Try to parse it as a Chrono Tz.
-    match Tz::from_str_insensitive(tz_name) {
+    match Tz::from_str(tz_name) {
         Ok(tz) => Ok(Value::from_object(PytzTimezone::new(tz))),
         Err(_) => Err(Error::new(
             ErrorKind::InvalidArgument,
@@ -115,42 +116,3 @@ impl minijinja::value::Object for PytzTimezone {
         write!(f, "{}", self.tz)
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use crate::modules::pytz::{timezone, PytzTimezone};
-    use chrono_tz::Tz;
-    use minijinja::Value;
-
-    #[test]
-    fn test_valid_timezone_utc() {
-        let args = vec![Value::from("UTC")];
-        let result = timezone(&args);
-        assert!(result.is_ok());
-
-        let actual = result.unwrap();
-        let expected = Value::from_object(PytzTimezone::new(chrono_tz::UTC));
-        assert_eq!(actual, expected);
-    }
-
-    #[test]
-    fn test_valid_timezone_case_insensitive() {
-        let args = vec![Value::from("asia/ho_chi_minh")];
-        let result = timezone(&args);
-        assert!(result.is_ok());
-
-        let actual = result.unwrap();
-        let expected = Value::from_object(PytzTimezone::new(Tz::Asia__Ho_Chi_Minh));
-        assert_eq!(actual, expected);
-    }
-
-    #[test]
-    fn test_invalid_timezone() {
-        let args = vec![Value::from("Invalid/Zone")];
-        let result = timezone(&args);
-        assert!(result.is_err());
-
-        let err = result.unwrap_err();
-        assert!(err.to_string().contains("Invalid timezone name"));
-    }
-}