Skip to content

Commit 6f3c9de

Browse files
axellpadillaAxell Padilla
authored andcommitted
fix to make drop_schema_name usable and test pass
1 parent bcf4ac9 commit 6f3c9de

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

22
{% macro sqlserver__drop_schema_named(schema_name) %}
3-
{% set schema_relation = api.Relation.create(schema=schema_name) %}
3+
{% set schema_relation = api.Relation.create(schema=schema_name, database=target.database) %}
44
{{ adapter.drop_schema(schema_relation) }}
55
{% endmacro %}
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import pytest
21
from dbt.tests.adapter.relations.test_changing_relation_type import BaseChangeRelationTypeValidator
32
from dbt.tests.adapter.relations.test_dropping_schema_named import BaseDropSchemaNamed
43

@@ -7,12 +6,5 @@ class TestChangeRelationTypeValidator(BaseChangeRelationTypeValidator):
76
pass
87

98

10-
@pytest.mark.xfail(
11-
reason="""
12-
Test fails as its not passing Use[] properly.
13-
`Use[None]` is called, should be `User[TestDB]`
14-
Unclear why the macro doens't pass it properly.
15-
"""
16-
)
179
class TestDropSchemaNamed(BaseDropSchemaNamed):
1810
pass

0 commit comments

Comments
 (0)