refactor(keymaps/utils): replace lazy_shell_cmd with lazy_cmd_with_window and update usages

Replaces the `lazy_shell_cmd` function with `lazy_cmd_with_window` for improved naming and consistency. Updates all keymap modules to use the new function. Also refactors `cmd_with_fidget` to `lazy_cmd_with_fidget` and updates its implementation and usages accordingly. Removes redundant error handling for required modules.

Author: dcai

lua/dcai/keymaps/git.lua

@@ -1,7 +1,7 @@
 local utils = require('dcai.keymaps.utils')
 
 local function lazy_git_cmd(opts, desc)
-  return utils.lazy_shell_cmd('git', opts, desc)
+  return utils.lazy_cmd_with_window('git', opts, desc)
 end
 
 local git_keymap = {
@@ -35,7 +35,7 @@ local git_keymap = {
   },
   {
     '<leader>gG',
-    utils.cmd_with_fidget('git', { 'auto-commit-and-push' }),
+    utils.lazy_cmd_with_fidget('git', { 'auto-commit-and-push' }),
     desc = 'git ai commit and push',
   },
   { '<leader>gd', '<cmd>Git diff<cr>', desc = 'fugitive diff' },

lua/dcai/keymaps/notes.lua

@@ -46,7 +46,7 @@ local notes_keymap = {
         vim.g.logger.warn('must be markdown file')
         return
       end
-      utils.lazy_shell_cmd(
+      utils.lazy_cmd_with_window(
         'doku-publish.py',
         -- args should be evaluated when the function is called
         { disable_popup = false, args = { vim.fn.expand('%:p') } }

lua/dcai/keymaps/openthings.lua

@@ -21,7 +21,7 @@ local openthings_keymap = {
     '<leader>od',
     function()
       -- has to be wrapped because dir must be lazy evaluated
-      utils.lazy_shell_cmd(
+      utils.lazy_cmd_with_window(
         'open',
         { disable_popup = true, args = { vim.fn.expand('%:p:h') } },
         'open folder'
@@ -33,7 +33,7 @@ local openthings_keymap = {
     '<leader>of',
     function()
       -- has to be wrapped because filename must be lazy evaluated
-      utils.lazy_shell_cmd(
+      utils.lazy_cmd_with_window(
         zed,
         { disable_popup = true, args = { vim.fn.expand('%:p') } },
         'open file in zed'

lua/dcai/keymaps/utils.lua

@@ -1,6 +1,6 @@
 local M = {}
 
-local function lazy_shell_cmd(command, opts, desc)
+local function lazy_cmd_with_window(command, opts, desc)
   return function()
     local plenary_loaded, Job = pcall(require, 'plenary.job')
     if not plenary_loaded then
@@ -54,28 +54,12 @@ local function lazy_shell_cmd(command, opts, desc)
       :start()
   end
 end
+M.lazy_cmd_with_window = lazy_cmd_with_window
 
-M.lazy_shell_cmd = lazy_shell_cmd
-
-M.cmd_with_fidget = function(command, args, opts)
+M.lazy_cmd_with_fidget = function(command, args, opts)
   return function()
-    local plenary_loaded, Job = pcall(require, 'plenary.job')
-    if not plenary_loaded then
-      vim.notify(
-        'plenary.nvim is required for cmd_with_fidget',
-        vim.log.levels.ERROR
-      )
-      return
-    end
-
-    local fidget_loaded, fidget_progress = pcall(require, 'fidget.progress')
-    if not fidget_loaded then
-      vim.notify(
-        'fidget.nvim is required for cmd_with_fidget',
-        vim.log.levels.ERROR
-      )
-      return
-    end
+    local Job = require('plenary.job')
+    local fidget_progress = require('fidget.progress')
 
     opts = opts or {}
     local cwd = opts.cwd or vim.fn.getcwd()