Beginning logging implementation

Author: dcarbone

src/HttpRequest.php

@@ -31,11 +31,11 @@ class HttpRequest
     private $_Config;
 
     /** @var string */
-    private $_method;
+    public $method;
     /** @var string */
-    private $_path;
+    public $path;
     /** @var string */
-    private $_url;
+    public $url;
 
     /** @var array */
     private $_curlOpts = array();
@@ -59,10 +59,11 @@ class HttpRequest
      */
     public function __construct($method, $path, Config $config, $body = null)
     {
-        $this->params = new Params();
         $this->_Config = $config;
-        $this->_method = strtolower($method);
-        $this->_path = $path;
+
+        $this->params = new Params();
+        $this->method = strtolower($method);
+        $this->path = $path;
 
         if ('' !== ($dc = $config->getDatacenter()))
             $this->params['dc'] = $dc;
@@ -131,9 +132,16 @@ public function setWriteOptions(WriteOptions $writeOptions = null)
      */
     public function execute()
     {
-        $this->_url = $this->_buildUrl();
+        $this->url = sprintf(
+            '%s/%s?%s',
+            $this->_Config->compileAddress(),
+            ltrim(trim($this->path), "/"),
+            $this->params
+        );
+
+        Logger::log('debug', 'Executing '.$this->method.' request '.$this->url.($this->body ? ' with body "'.$this->body.'"':''));
 
-        switch($this->_method)
+        switch($this->method)
         {
             case 'get':
                 // no prep needed
@@ -149,34 +157,41 @@ public function execute()
                 return [null, new Error(sprintf(
                     '%s - PHPConsulAPI currently does not support queries made using the "%s" method.',
                     get_class($this),
-                    $this->_method
+                    $this->method
                 ))];
         }
 
-        $ch = curl_init($this->_url);
+        $ch = curl_init($this->url);
 
         if (false === $ch)
         {
-            return [null, new Error(sprintf(
+            $err = new Error(sprintf(
                 '%s::execute - Unable to initialize CURL resource with URL "%s"',
                 get_class($this),
-                $this->_url
-            ))];
+                $this->url
+            ));
+            Logger::log('error', $err);
+            return [null, $err];
         }
 
         if (false === curl_setopt_array($ch, $this->_curlOpts))
         {
-            return [null, new Error(sprintf(
+            $err = new Error(sprintf(
                 '%s - Unable to set specified Curl options, please ensure you\'re passing in valid constants.  Specified options: %s',
                 get_class($this),
                 json_encode($this->_curlOpts)
-            ))];
+            ));
+            Logger::log('error', $err);
+            return [null, $err];
         }
 
         $response = new HttpResponse(curl_exec($ch), curl_getinfo($ch), curl_error($ch));
 
         curl_close($ch);
 
+
+        Logger::log('debug', 'Response received - Code: '.$response->httpCode.'; Body: '.$response->body.'; ');
+
         return [$response, null];
     }
 
@@ -217,17 +232,4 @@ private function _compileBody()
                 return '';
         }
     }
-
-    /**
-     * @return string
-     */
-    private function _buildUrl()
-    {
-        return sprintf(
-            '%s/%s?%s',
-            $this->_Config->compileAddress(),
-            ltrim(trim($this->_path), "/"),
-            $this->params
-        );
-    }
 }

var/logs/.gitignore

@@ -0,0 +1 @@
+!.gitignore