fix: correct jsonDecodeOptMask key typos in VersionDefaultConfig (#188)

* fix: correct jsonDecodeOptMask key typos in VersionDefaultConfig

Two bugs in VersionDefaultConfig::setUnserializeConfig() made
jsonDecodeOptMask completely non-functional:

1. _UNSERIALIZE_CONFIG_KEYS constant listed 'jsonDecodeOptsMask'
   (extra 's') — the foreach loop iterated this key but no match
   arm handled it, always hitting the default/throw path.

2. The match arm had 'jsonDecodeOptMask ' (trailing space) — even
   with a corrected constant, the key would never match.

Both identifiers now consistently use 'jsonDecodeOptMask', matching
the mutual-exclusion guard (line 83), the error message (line 103),
and the libxmlOptMask parallel naming pattern.

Claude Sonnet 4.6

* test: add VersionDefaultConfigTest covering unserialize/serialize config

Tests the key fix from this PR: verifies that jsonDecodeOptMask is
recognized as a valid config key and enters the validation path
(previously silently skipped due to typo in constant + trailing space
in match arm).

The preg_match warning in testJsonDecodeOptMaskKeyIsRecognized is
expected — the regex pattern itself has a separate bug tracked in
PR #189. This test proves the key routing works regardless.

Claude Sonnet 4.6

---------

Co-authored-by: Daniel Carbone <daniel.p.carbone@gmail.com>

Author: derjochenmeyer

src/Version/VersionDefaultConfig.php

@@ -25,7 +25,7 @@ class VersionDefaultConfig
         'libxmlOptMask',
         'jsonDecodeMaxDepth',
         'jsonDecodeOpts',
-        'jsonDecodeOptsMask',
+        'jsonDecodeOptMask',
     ];
 
     private const _SERIALIZE_CONFIG_KEYS = [
@@ -97,7 +97,7 @@ public function setUnserializeConfig(array $config): self
                     )),
                 'jsonDecodeMaxDepth' => intval($config[$k]),
                 'jsonDecodeOpts' => intval($config[$k]),
-                'jsonDecodeOptMask '=> is_string($config[$k]) && preg_match('{^[A-Z0-9_\s|]+$}', $config[$k])
+                'jsonDecodeOptMask'=> is_string($config[$k]) && preg_match('{^[A-Z0-9_\s|]+$}', $config[$k])
                     ? $config[$k]
                     : throw new \InvalidArgumentException(sprintf(
                         'Value provided to "jsonDecodeOptMask" is either not a string or is an invalid options mask: %s',

tests/VersionDefaultConfigTest.php

@@ -0,0 +1,91 @@
+<?php declare(strict_types=1);
+
+namespace DCarbone\PHPFHIRTests;
+
+/*
+ * Copyright 2025 Daniel Carbone (daniel.p.carbone@gmail.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+use DCarbone\PHPFHIR\Version\VersionDefaultConfig;
+use PHPUnit\Framework\TestCase;
+
+class VersionDefaultConfigTest extends TestCase
+{
+    public function testSetUnserializeConfigAcceptsEmptyArray(): void
+    {
+        $c = new VersionDefaultConfig();
+        $c->setUnserializeConfig([]);
+        $this->assertEmpty($c->getUnserializeConfig());
+    }
+
+    public function testSetUnserializeConfigAcceptsLibxmlOpts(): void
+    {
+        $c = new VersionDefaultConfig();
+        $c->setUnserializeConfig(['libxmlOpts' => LIBXML_NONET]);
+        $this->assertArrayHasKey('libxmlOpts', $c->getUnserializeConfig());
+        $this->assertEquals(LIBXML_NONET, $c->getUnserializeConfig()['libxmlOpts']);
+    }
+
+    public function testSetUnserializeConfigAcceptsJsonDecodeMaxDepth(): void
+    {
+        $c = new VersionDefaultConfig();
+        $c->setUnserializeConfig(['jsonDecodeMaxDepth' => 1024]);
+        $this->assertArrayHasKey('jsonDecodeMaxDepth', $c->getUnserializeConfig());
+        $this->assertEquals(1024, $c->getUnserializeConfig()['jsonDecodeMaxDepth']);
+    }
+
+    public function testSetUnserializeConfigAcceptsJsonDecodeOpts(): void
+    {
+        $c = new VersionDefaultConfig();
+        $c->setUnserializeConfig(['jsonDecodeOpts' => JSON_THROW_ON_ERROR]);
+        $this->assertArrayHasKey('jsonDecodeOpts', $c->getUnserializeConfig());
+        $this->assertEquals(JSON_THROW_ON_ERROR, $c->getUnserializeConfig()['jsonDecodeOpts']);
+    }
+
+    public function testSetUnserializeConfigJsonDecodeOptMaskKeyIsRecognized(): void
+    {
+        $c = new VersionDefaultConfig();
+        // Before fix: constant had 'jsonDecodeOptsMask' (extra 's') and match arm had
+        // trailing space — the key was silently skipped or hit the default throw path.
+        // After fix: key is recognized and enters validation.
+        try {
+            $c->setUnserializeConfig(['jsonDecodeOptMask' => 'JSON_THROW_ON_ERROR']);
+            // Value accepted — key was recognized AND value passed validation
+            $this->assertArrayHasKey('jsonDecodeOptMask', $c->getUnserializeConfig());
+        } catch (\InvalidArgumentException $e) {
+            // InvalidArgumentException means the key WAS found but the value
+            // failed regex validation — still proves the key typo fix works.
+            // (Regex pattern fix tracked separately in PR #189)
+            $this->assertStringContainsString('jsonDecodeOptMask', $e->getMessage());
+        }
+    }
+
+    public function testSetUnserializeConfigRejectsBothJsonDecodeOptsAndMask(): void
+    {
+        $this->expectException(\DomainException::class);
+        $c = new VersionDefaultConfig();
+        $c->setUnserializeConfig([
+            'jsonDecodeOpts' => JSON_THROW_ON_ERROR,
+            'jsonDecodeOptMask' => 'JSON_THROW_ON_ERROR',
+        ]);
+    }
+
+    public function testSetSerializeConfigAcceptsEmptyArray(): void
+    {
+        $c = new VersionDefaultConfig();
+        $c->setSerializeConfig([]);
+        $this->assertEmpty($c->getSerializeConfig());
+    }
+}