PHP8 Attributes

[PaulHendriks]

I'd be nice to have PHP8 attributes with each model, so we can parse it in our online Swagger api documentation.
Is this something that you'd consider building into the builder?

[dcarbone]

Ah, yeah I think this could be very useful.

I'm not very familiar with the new Attribute system, and its been quite some time since I defined OpenAPI markup for a PHP project.

Would I need to add a dependency on zircote/swagger-php, or can this be done with the built-in PHP8 Attribute classes?

[PaulHendriks]

Attributes are native to PHP from version 8: https://www.php.net/manual/en/language.attributes.overview.php
No extra dependency needed besides the PHP8 requirement.

[dcarbone]

I did see that, but it doesn't actually tell me anything about how they work. Most of the examples I see involve using them as a way to use runtime reflection to perform actions that, in my opinion, shouldn't require reflection in the first place.

The way we used to handle "exposing" non-public class property types for documentation & type hinting prior to Attributes was to have a class-level docblock with @property annotations.

Would this be sufficient, or do you have a more concrete example of how to define Attributes so they will be consumable by your openapi tool?

[dcarbone]

@PaulHendriks I have made a quick PR to add attribute property annotations to the output classes: https://github.com/dcarbone/php-fhir/pull/166/files

Is this sufficient for your needs, or were you thinking of something different?

[PaulHendriks]

Yes, this looks like what i can use for our project 👍
Thank you for your quick response :)

[dcarbone]

Sounds good, I'll get a release cut this evening!

[dcarbone]

@PaulHendriks I have released v4.0.0-rc6 with this output. Let me know if you run into any issues!