Skip to content

Commit ccdbca9

Browse files
authored
chore: Update persona configuration structure and diff exclusions (#367)
Fix `.jp/config/personas/po.toml` to use `[assistant.system_prompt]` instead of the top-level `[system_prompt]`. Additionally, update `committer` and `stager` personas to exclude `.jp/conversations` when executing `git diff-index`. This prevents transient conversation state from being included in the diffs processed by these personas, ensuring they focus on relevant code changes. Also removes an inadvertent leak of a Google API key from the conversation history. This key had already been rotated, but was still present in the history, causing automated bots to keep notifying us of a potential security breach. This does highlight the importance of vetting conversation history before committing it to a repository. We could potentially add a secrets scanner to JP itself, allowing users to configure whether to rewrite, error or warn when potential sensitive information is detected in conversation history. --------- Signed-off-by: Jean Mertz <git@jeanmertz.com>
1 parent dc93bd4 commit ccdbca9

File tree

5 files changed

+28
-14
lines changed

5 files changed

+28
-14
lines changed

.jp/config/personas/committer.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ params.arg = [
4141
".",
4242
":^crates/jp_llm/tests/fixtures",
4343
":^Cargo.lock",
44+
":^.jp/conversations",
4445
]
4546

4647
[style]

.jp/config/personas/po.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[assistant]
22
name = "Product Owner"
33

4-
[system_prompt]
4+
[assistant.system_prompt]
55
strategy = "append"
66
separator = "paragraph"
77
value = """

.jp/config/personas/stager.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ params.arg = [
4444
".",
4545
":^crates/jp_llm/tests/fixtures",
4646
":^Cargo.lock",
47+
":^.jp/conversations",
4748
]
4849

4950
[[conversation.attachments]]

.jp/conversations/17653152345-agentic-shepherd-open-issues-list/events.json

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@
100100
"lines": 10
101101
}
102102
},
103-
"results_file_link": "osc8"
103+
"results_file_link": "osc8",
104+
"parameters": "json"
104105
}
105106
},
106107
"crate_readme": {
@@ -139,7 +140,8 @@
139140
"run": "unattended",
140141
"style": {
141142
"inline_results": "off",
142-
"results_file_link": "full"
143+
"results_file_link": "full",
144+
"parameters": "json"
143145
}
144146
},
145147
"agentic_shepherd_run": {
@@ -173,7 +175,8 @@
173175
"run": "unattended",
174176
"style": {
175177
"inline_results": "off",
176-
"results_file_link": "full"
178+
"results_file_link": "full",
179+
"parameters": "json"
177180
}
178181
},
179182
"cargo_expand": {
@@ -198,7 +201,8 @@
198201
"run": "unattended",
199202
"style": {
200203
"inline_results": "off",
201-
"results_file_link": "full"
204+
"results_file_link": "full",
205+
"parameters": "json"
202206
}
203207
},
204208
"cargo_test": {
@@ -223,7 +227,8 @@
223227
"run": "unattended",
224228
"style": {
225229
"inline_results": "off",
226-
"results_file_link": "full"
230+
"results_file_link": "full",
231+
"parameters": "json"
227232
}
228233
},
229234
"fs_create_file": {
@@ -292,7 +297,8 @@
292297
"run": "unattended",
293298
"style": {
294299
"inline_results": "off",
295-
"results_file_link": "full"
300+
"results_file_link": "full",
301+
"parameters": "json"
296302
}
297303
},
298304
"fs_grep_user_docs": {
@@ -318,7 +324,8 @@
318324
"run": "unattended",
319325
"style": {
320326
"inline_results": "off",
321-
"results_file_link": "full"
327+
"results_file_link": "full",
328+
"parameters": "json"
322329
}
323330
},
324331
"fs_list_files": {
@@ -349,7 +356,8 @@
349356
"run": "unattended",
350357
"style": {
351358
"inline_results": "off",
352-
"results_file_link": "full"
359+
"results_file_link": "full",
360+
"parameters": "json"
353361
}
354362
},
355363
"fs_modify_file": {
@@ -401,7 +409,8 @@
401409
"run": "unattended",
402410
"style": {
403411
"inline_results": "off",
404-
"results_file_link": "full"
412+
"results_file_link": "full",
413+
"parameters": "json"
405414
}
406415
},
407416
"git_commit": {
@@ -420,7 +429,8 @@
420429
"run": "unattended",
421430
"style": {
422431
"inline_results": "full",
423-
"results_file_link": "full"
432+
"results_file_link": "full",
433+
"parameters": "json"
424434
}
425435
},
426436
"github_code_search": {
@@ -633,7 +643,8 @@
633643
"run": "unattended",
634644
"style": {
635645
"inline_results": "off",
636-
"results_file_link": "full"
646+
"results_file_link": "full",
647+
"parameters": "json"
637648
}
638649
},
639650
"github_pulls": {
@@ -670,7 +681,8 @@
670681
"run": "unattended",
671682
"style": {
672683
"inline_results": "off",
673-
"results_file_link": "full"
684+
"results_file_link": "full",
685+
"parameters": "json"
674686
}
675687
},
676688
"github_read_file": {

.jp/conversations/17659773217-google-api-streaming-event-conversion-issue/events.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)