Commit ccdbca9
authored
chore: Update persona configuration structure and diff exclusions (#367)
Fix `.jp/config/personas/po.toml` to use `[assistant.system_prompt]`
instead of the top-level `[system_prompt]`.
Additionally, update `committer` and `stager` personas to exclude
`.jp/conversations` when executing `git diff-index`. This prevents
transient conversation state from being included in the diffs processed
by these personas, ensuring they focus on relevant code changes.
Also removes an inadvertent leak of a Google API key from the
conversation history. This key had already been rotated, but was still
present in the history, causing automated bots to keep notifying us of a
potential security breach.
This does highlight the importance of vetting conversation history
before committing it to a repository. We could potentially add a secrets
scanner to JP itself, allowing users to configure whether to rewrite,
error or warn when potential sensitive information is detected in
conversation history.
---------
Signed-off-by: Jean Mertz <git@jeanmertz.com>1 parent dc93bd4 commit ccdbca9
File tree
5 files changed
+28
-14
lines changed- .jp
- config/personas
- conversations
- 17653152345-agentic-shepherd-open-issues-list
- 17659773217-google-api-streaming-event-conversion-issue
5 files changed
+28
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| |||
Lines changed: 24 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
142 | | - | |
| 143 | + | |
| 144 | + | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
| |||
173 | 175 | | |
174 | 176 | | |
175 | 177 | | |
176 | | - | |
| 178 | + | |
| 179 | + | |
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
| |||
198 | 201 | | |
199 | 202 | | |
200 | 203 | | |
201 | | - | |
| 204 | + | |
| 205 | + | |
202 | 206 | | |
203 | 207 | | |
204 | 208 | | |
| |||
223 | 227 | | |
224 | 228 | | |
225 | 229 | | |
226 | | - | |
| 230 | + | |
| 231 | + | |
227 | 232 | | |
228 | 233 | | |
229 | 234 | | |
| |||
292 | 297 | | |
293 | 298 | | |
294 | 299 | | |
295 | | - | |
| 300 | + | |
| 301 | + | |
296 | 302 | | |
297 | 303 | | |
298 | 304 | | |
| |||
318 | 324 | | |
319 | 325 | | |
320 | 326 | | |
321 | | - | |
| 327 | + | |
| 328 | + | |
322 | 329 | | |
323 | 330 | | |
324 | 331 | | |
| |||
349 | 356 | | |
350 | 357 | | |
351 | 358 | | |
352 | | - | |
| 359 | + | |
| 360 | + | |
353 | 361 | | |
354 | 362 | | |
355 | 363 | | |
| |||
401 | 409 | | |
402 | 410 | | |
403 | 411 | | |
404 | | - | |
| 412 | + | |
| 413 | + | |
405 | 414 | | |
406 | 415 | | |
407 | 416 | | |
| |||
420 | 429 | | |
421 | 430 | | |
422 | 431 | | |
423 | | - | |
| 432 | + | |
| 433 | + | |
424 | 434 | | |
425 | 435 | | |
426 | 436 | | |
| |||
633 | 643 | | |
634 | 644 | | |
635 | 645 | | |
636 | | - | |
| 646 | + | |
| 647 | + | |
637 | 648 | | |
638 | 649 | | |
639 | 650 | | |
| |||
670 | 681 | | |
671 | 682 | | |
672 | 683 | | |
673 | | - | |
| 684 | + | |
| 685 | + | |
674 | 686 | | |
675 | 687 | | |
676 | 688 | | |
| |||
Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.
0 commit comments