Proper subtypes

Author: dcelisgarza

src/20_Optimisation/02_CrossValidation/01_Base_CrossValidation.jl

@@ -1,12 +1,27 @@
 abstract type CrossValidationEstimator <: AbstractEstimator end
 abstract type CrossValidationResult <: AbstractResult end
 abstract type CrossValidationAlgorithm <: AbstractAlgorithm end
+
 abstract type OptimisationCrossValidationEstimator <: CrossValidationEstimator end
 abstract type SequentialCrossValidationEstimator <: OptimisationCrossValidationEstimator end
 abstract type NonSequentialCrossValidationEstimator <: OptimisationCrossValidationEstimator end
-abstract type SequentialCrossValidationResult <: CrossValidationResult end
-abstract type NonSequentialCrossValidationResult <: CrossValidationResult end
-abstract type SequentialNonOptimisationCrossValidationResult <: CrossValidationResult end
+
+abstract type OptimisationCrossValidationResult <: CrossValidationResult end
+abstract type SequentialCrossValidationResult <: OptimisationCrossValidationResult end
+abstract type NonSequentialCrossValidationResult <: OptimisationCrossValidationResult end
+
+abstract type NonOptimisationCrossValidationEstimator <: CrossValidationEstimator end
+abstract type NonOptimisationSequentialCrossValidationEstimator <:
+              NonOptimisationCrossValidationEstimator end
+abstract type NonOptimisationNonSequentialCrossValidationEstimator <:
+              NonOptimisationCrossValidationEstimator end
+
+abstract type NonOptimisationCrossValidationResult <: CrossValidationResult end
+abstract type NonOptimisationSequentialCrossValidationResult <:
+              NonOptimisationCrossValidationResult end
+abstract type NonOptimisationNonSequentialCrossValidationResult <:
+              NonOptimisationCrossValidationResult end
+
 struct PredictionReturnsResult{T1, T2, T3, T4, T5, T6, T7} <: AbstractReturnsResult
     nx::T1
     X::T2

src/20_Optimisation/02_CrossValidation/05_MultipleRandomised.jl

@@ -1,5 +1,5 @@
 struct MultipleRandomised{T1, T2, T3, T4, T5, T6, T7} <:
-       SequentialNonOptimisationCrossValidationResult
+       NonOptimisationSequentialCrossValidationEstimator
     cv::T1
     subset_size::T2
     n_subsets::T3
@@ -30,7 +30,8 @@ function MultipleRandomised(cv::WalkForwardEstimator; subset_size::Integer = 1,
                             seed::Option{<:Integer} = nothing)
     return MultipleRandomised(cv, subset_size, n_subsets, max_comb, window_size, rng, seed)
 end
-struct MultipleRandomisedResult{T1, T2, T3, T4} <: SequentialCrossValidationResult
+struct MultipleRandomisedResult{T1, T2, T3, T4} <:
+       NonOptimisationSequentialCrossValidationResult
     train_idx::T1
     test_idx::T2
     asset_idx::T3