Limit binary size, and range for key_ranges

Author: dcherian

src/zarr/testing/strategies.py

@@ -160,7 +160,9 @@ def basic_indices(draw: st.DrawFn, *, shape: tuple[int], **kwargs):  # type: ign
     )
 
 
-def key_ranges(keys: SearchStrategy = node_names) -> SearchStrategy[list[int]]:
+def key_ranges(
+    keys: SearchStrategy = node_names, max_size: int | None = None
+) -> SearchStrategy[list[int]]:
     """
     Function to generate key_ranges strategy for get_partial_values()
     returns list strategy w/ form::
@@ -169,7 +171,8 @@ def key_ranges(keys: SearchStrategy = node_names) -> SearchStrategy[list[int]]:
          (key, (range_start, range_step)),...]
     """
     byte_ranges = st.tuples(
-        st.none() | st.integers(min_value=0), st.none() | st.integers(min_value=0)
+        st.none() | st.integers(min_value=0, max_value=max_size),
+        st.none() | st.integers(min_value=0, max_value=max_size),
     )
     key_tuple = st.tuples(keys, byte_ranges)
     key_range_st = st.lists(key_tuple, min_size=1, max_size=10)

tests/v3/test_store/test_stateful_store.py

@@ -20,6 +20,8 @@
 from zarr.testing.strategies import key_ranges
 from zarr.testing.strategies import keys as zarr_keys
 
+MAX_BINARY_SIZE = 100
+
 
 class SyncStoreWrapper(zarr.core.sync.SyncMixin):
     def __init__(self, store: Store) -> None:
@@ -116,7 +118,7 @@ def __init__(self, store: Store) -> None:
     def init_store(self):
         self.store.clear()
 
-    @rule(key=zarr_keys, data=st.binary(min_size=0, max_size=100))
+    @rule(key=zarr_keys, data=st.binary(min_size=0, max_size=MAX_BINARY_SIZE))
     def set(self, key: str, data: DataObject) -> None:
         note(f"(set) Setting {key!r} with {data}")
         assert not self.store.mode.readonly
@@ -144,7 +146,9 @@ def get_invalid_zarr_keys(self, key: str, data: DataObject) -> None:
     @precondition(lambda self: len(self.model.keys()) > 0)
     @rule(data=st.data())
     def get_partial_values(self, data: DataObject) -> None:
-        key_range = data.draw(key_ranges(keys=st.sampled_from(sorted(self.model.keys()))))
+        key_range = data.draw(
+            key_ranges(keys=st.sampled_from(sorted(self.model.keys())), max_size=MAX_BINARY_SIZE)
+        )
         note(f"(get partial) {key_range=}")
         obs_maybe = self.store.get_partial_values(key_range, self.prototype)
         observed = []
@@ -246,6 +250,6 @@ def mk_test_instance_sync():
 
     if isinstance(sync_store, ZipStore):
         pytest.skip(reason="ZipStore does not support delete")
-    if isinstance(sync_store, LocalStore):
-        pytest.skip(reason="This test does not handle subdirectories")
+    # if isinstance(sync_store, LocalStore):
+    #     pytest.skip(reason="This test does not handle subdirectories")
     run_state_machine_as_test(mk_test_instance_sync, settings=Settings(report_multiple_bugs=True))