Make MemoryStore serialiazable (zarr-developers#2204)

Author: TomAugspurger

src/zarr/store/memory.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from collections.abc import AsyncGenerator, MutableMapping
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING
 
 from zarr.abc.store import Store
 from zarr.core.buffer import Buffer, gpu
@@ -55,12 +55,6 @@ def __eq__(self, other: object) -> bool:
             and self.mode == other.mode
         )
 
-    def __setstate__(self, state: Any) -> None:
-        raise NotImplementedError(f"{type(self)} cannot be pickled")
-
-    def __getstate__(self) -> None:
-        raise NotImplementedError(f"{type(self)} cannot be pickled")
-
     async def get(
         self,
         key: str,

tests/v3/test_store/test_memory.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import pickle
-
 import pytest
 
 from zarr.core.buffer import Buffer, cpu, gpu
@@ -48,16 +46,6 @@ def test_store_supports_partial_writes(self, store: MemoryStore) -> None:
     def test_list_prefix(self, store: MemoryStore) -> None:
         assert True
 
-    def test_serizalizable_store(self, store: MemoryStore) -> None:
-        with pytest.raises(NotImplementedError):
-            store.__getstate__()
-
-        with pytest.raises(NotImplementedError):
-            store.__setstate__({})
-
-        with pytest.raises(NotImplementedError):
-            pickle.dumps(store)
-
 
 @gpu_test
 class TestGpuMemoryStore(StoreTests[GpuMemoryStore, gpu.Buffer]):
@@ -92,13 +80,3 @@ def test_store_supports_partial_writes(self, store: GpuMemoryStore) -> None:
 
     def test_list_prefix(self, store: GpuMemoryStore) -> None:
         assert True
-
-    def test_serizalizable_store(self, store: MemoryStore) -> None:
-        with pytest.raises(NotImplementedError):
-            store.__getstate__()
-
-        with pytest.raises(NotImplementedError):
-            store.__setstate__({})
-
-        with pytest.raises(NotImplementedError):
-            pickle.dumps(store)