Skip to content

Commit 861769f

Browse files
committed
fix ssl handle error to cancel instead of ignoring
1 parent 8ebcf25 commit 861769f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424

2525
# Step 2: Set up JDK (Java Development Kit)
2626
- name: Set up JDK 17
27-
uses: actions/setup-java@v3
27+
uses: actions/setup-java@v4
2828
with:
2929
distribution: 'temurin'
3030
java-version: '17'
@@ -40,7 +40,7 @@ jobs:
4040
# Step 5a: Upload ZIP as Local Artifact for Push/PR
4141
- name: Upload ZIP as Local Artifact
4242
if: github.event_name != 'release' # Only upload to local artifacts on push or PR
43-
uses: actions/upload-artifact@v3
43+
uses: actions/upload-artifact@v4
4444
with:
4545
name: webview-godot-android-zip
4646
path: webview-godot-android.zip

plugin/src/main/java/org/godotengine/plugin/android/template/GodotAndroidPlugin.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ class GodotAndroidPlugin(godot: Godot) : GodotPlugin(godot) {
148148
}
149149

150150
override fun onReceivedSslError(view: WebView?, handler: android.webkit.SslErrorHandler?, error: android.net.http.SslError?) {
151-
// Handle SSL errors, ideally show some kind of dialog to the user
152-
handler?.proceed() // For demo purposes, ignore SSL errors. Not recommended in production.
151+
Log.e(pluginName, "Ssl error")
152+
handler?.cancel()
153153
}
154154

155155
override fun onPageStarted(view: WebView?, url: String?, favicon: android.graphics.Bitmap?) {

0 commit comments

Comments
 (0)