fix: Missing variable name (#106)

Also fixed a build issue by creating a netlify.toml file.  May need some additional fixes on deployment/update of version numbers

* fix: Missing variable name
* fix: linting issues

* fix: Undo format changes

* Change to ubuntu-latest for build

* fix: node version being used to run

* Update to use node package for building

* Try to build

* fix: build issue

* Add netlify toml file to try to update to a newer node version for
building

* Update publish directory

* Update test section

Author: wayfarer3130

.eslintrc.js

@@ -2,7 +2,7 @@ module.exports = {
   root: true,
   extends: ['airbnb-base', 'prettier'],
   rules: {
-    'import/extensions': "always", // Better for native ES Module usage
+    'import/extensions': 2, // Better for native ES Module usage
     'no-console': 0, // We can remove this later
     'no-underscore-dangle': 0,
     'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],

.github/workflows/publish-package.yml

@@ -7,26 +7,22 @@ on:
 
 jobs:
   publish-package:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu:latest
     environment: publish
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v1
-        with:
-          node-version: 16
-
-      - name: Install packages
-        uses: bahmutov/npm-install@v1
+      - name: Install
+        uses: oven-sh/setup-bun@v2
+        run: bun install
 
       - name: Run build
-        run: npm run build
+        run: bun run build
 
       - name: Run tests
-        run: npm run test
+        run: bun run test
 
       - name: Semantic release
         uses: cycjimmy/semantic-release-action@v3

.github/workflows/tests.yml

@@ -6,22 +6,18 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
+        uses: actions/checkout@v4
 
       - name: Install packages
-        uses: bahmutov/npm-install@v1
+        uses: oven-sh/setup-bun@v2
+        run: bun install
 
       - name: Run build
-        run: npm run build
+        run: bun run build
 
       - name: Run tests
-        run: npm run test
+        run: bun run test

.gitignore

@@ -31,6 +31,7 @@ bower_components
 
 # Build directory
 build/
+dist/
 
 # Dependency directories
 node_modules/
@@ -56,12 +57,16 @@ typings/
 
 # Yarn lock file
 yarn.lock
+bun.lock
 
 # dotenv environment variables file
 .env
 
 .idea
 
+*.code-workspace
+.vscode/
+
 # docker files created by the docker containers for testing
 tmp
 

.travis.yml

@@ -19,4 +19,5 @@ before_script:
 
 script:
   - npm install
+  - echo travis build definition
   - npm run build

netlify.toml

@@ -0,0 +1,16 @@
+[build]
+  command = "npm install && npm run build"
+  publish = "build"
+
+[build.environment]
+  NODE_VERSION = "20"
+  NPM_FLAGS = "--legacy-peer-deps"  # Optional, useful if you run into dependency resolution issues
+
+[build.lifecycle]
+  # This will run before the build command
+  onPostBuild = "npm run test"
+
+[[redirects]]
+  from = "/*"
+  to = "/index.html"
+  status = 200

package-lock.json

@@ -1125,7 +1125,7 @@ class DICOMwebClient {
     const url = `${this.wadoURL}/studies/${options.studyInstanceUID}/series/${options.seriesInstanceUID}/metadata`;
 
     const request = getRequestOptions(options.request)
-    return this._httpGetApplicationJson(url, {}, false, withCredentials);
+    return this._httpGetApplicationJson(url, {}, request);
   }
 
   /**
@@ -1140,7 +1140,6 @@ class DICOMwebClient {
    */
   searchForInstances(options = {}) {
     let url = this.qidoURL;
-    let withCredentials = false;
     if ('studyInstanceUID' in options) {
       url += `/studies/${options.studyInstanceUID}`;
       if ('seriesInstanceUID' in options) {