Skip to content

fix: Missing variable name #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 17, 2025
Merged

fix: Missing variable name #106

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dbbf4c8
fix: Missing variable name
wayfarer3130 Jun 13, 2025
fcd997d
fix: linting issues
wayfarer3130 Jun 13, 2025
8d2cc15
Merge remote-tracking branch 'origin/master' into fix/withCredentials…
wayfarer3130 Jun 13, 2025
2efe1ae
fix: Undo format changes
wayfarer3130 Jun 13, 2025
9aa4534
Change to ubuntu-latest for build
wayfarer3130 Jun 16, 2025
9ea9b51
fix: node version being used to run
wayfarer3130 Jun 16, 2025
c728a87
Update to use node package for building
wayfarer3130 Jun 16, 2025
0e01614
Try to build
wayfarer3130 Jun 17, 2025
95536c1
fix: build issue
wayfarer3130 Jun 17, 2025
578da04
Add netlify toml file to try to update to a newer node version for
wayfarer3130 Jun 17, 2025
1392997
Update publish directory
wayfarer3130 Jun 17, 2025
e8efedf
Update test section
wayfarer3130 Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Copy link
Contributor Author

@wayfarer3130 wayfarer3130 Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer a valid code, so I applied the allowed value.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = {
root: true,
extends: ['airbnb-base', 'prettier'],
rules: {
'import/extensions': "always", // Better for native ES Module usage
'import/extensions': 2, // Better for native ES Module usage
Copy link
Contributor

@pieper pieper Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the symbol is changed to a magic number? What does 2 mean?

'no-console': 0, // We can remove this later
'no-underscore-dangle': 0,
'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],
Expand Down
3 changes: 1 addition & 2 deletions src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ class DICOMwebClient {
const url = `${this.wadoURL}/studies/${options.studyInstanceUID}/series/${options.seriesInstanceUID}/metadata`;

const request = getRequestOptions(options.request)
return this._httpGetApplicationJson(url, {}, false, withCredentials);
return this._httpGetApplicationJson(url, {}, request);
}

/**
Expand All @@ -1140,7 +1140,6 @@ class DICOMwebClient {
*/
searchForInstances(options = {}) {
let url = this.qidoURL;
let withCredentials = false;
if ('studyInstanceUID' in options) {
url += `/studies/${options.studyInstanceUID}`;
if ('seriesInstanceUID' in options) {
Expand Down
Loading