Refactor CMake: unify solver build, exclude unit tests from coverage

* Built solver sources into a shared object library (solver_objs)
  so they can be reused by both the main executable and unit tests.
  This avoids recompiling solver sources twice when ENABLE_UNIT_TEST
  is enabled.
* Excluded unit tests from code coverage by removing coverage flags
  from the run_all_unit_tests target (-fno-profile-arcs, -fno-test-coverage).
  This prevents .gcda files from being generated for test code,
  ensuring coverage only reflects solver sources.

Author: dcodoni

Code/Source/solver/CMakeLists.txt

@@ -241,12 +241,20 @@ if(USE_TRILINOS)
   link_directories(${Trilinos_TPL_LIBRARY_DIRS})
 endif()
 
-simvascular_add_executable(${SV_MULTIPHYSICS_EXE}
-  SRCS ${CSRCS}
-  DEV_SCRIPT_NAME "mysvmultiphysics"
-  INSTALL_SCRIPT_NAME "svmultiphysics"
-  INSTALL_COMP CoreExecutables
-  INSTALL_DESTINATION ${SV_INSTALL_RUNTIME_DIR})
+# simvascular_add_executable(${SV_MULTIPHYSICS_EXE}
+#   SRCS ${CSRCS}
+#   DEV_SCRIPT_NAME "mysvmultiphysics"
+#   INSTALL_SCRIPT_NAME "svmultiphysics"
+#   INSTALL_COMP CoreExecutables
+#   INSTALL_DESTINATION ${SV_INSTALL_RUNTIME_DIR})
+
+# Build solver code (all sources except main.cpp) into a library
+list(REMOVE_ITEM CSRCS "main.cpp")
+add_library(solver_objs OBJECT ${CSRCS})
+add_library(solver STATIC $<TARGET_OBJECTS:solver_objs>)
+
+# Solver main executable
+add_executable(${SV_MULTIPHYSICS_EXE} main.cpp $<TARGET_OBJECTS:solver_objs>)
 
 target_link_libraries(${SV_MULTIPHYSICS_EXE}
   ${GLOBAL_LIBRARIES}
@@ -284,15 +292,12 @@ if(ENABLE_COVERAGE)
   find_program(LCOV lcov REQUIRED)
   find_program(GENHTML genhtml REQUIRED)
 
-  # get parent of project source dir
-  get_filename_component(PARENT_SOURCE_DIR "${PROJECT_SOURCE_DIR}" DIRECTORY)
-
   # add coverage target
   add_custom_target(coverage
     # gather data
     COMMAND ${LCOV} --directory . --capture --output-file coverage.info
     # exclude externals
-    COMMAND ${LCOV} --remove coverage.info -o coverage.info '/usr/*' '/opt/*' "${PROJECT_SOURCE_DIR}/ThirdParty/*" "${PARENT_SOURCE_DIR}/tests/unitTests/*" '/Library/*' 'v1/*'
+    COMMAND ${LCOV} --remove coverage.info -o coverage.info '/usr/*' '/opt/*' "${PROJECT_SOURCE_DIR}/ThirdParty/*" '/Library/*' 'v1/*'
     # generate report
     COMMAND ${GENHTML} --demangle-cpp -o coverage coverage.info
     WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
@@ -331,22 +336,34 @@ if(ENABLE_UNIT_TEST)
     message(STATUS "TEST_SOURCE: ${TEST_SOURCE}")
   endforeach()  
 
-  list(REMOVE_ITEM CSRCS "main.cpp")
-  list(APPEND CSRCS ${TEST_SOURCES})
+  # list(REMOVE_ITEM CSRCS "main.cpp")
+  # list(APPEND CSRCS ${TEST_SOURCES})
 
   # include source files (same as what svMultiPhysics does except for main.cpp)
-  add_executable(run_all_unit_tests ${CSRCS})
-  
-  if(USE_TRILINOS)
-    target_link_libraries(run_all_unit_tests ${Trilinos_LIBRARIES} ${Trilinos_TPL_LIBRARIES})
+  # add_executable(run_all_unit_tests ${CSRCS})
+  add_executable(run_all_unit_tests ${TEST_SOURCES})
+
+  # Remove coverage flags from unit tests
+  if(ENABLE_COVERAGE)
+    target_compile_options(run_all_unit_tests PRIVATE -U_FORTIFY_SOURCE)
+    target_compile_options(run_all_unit_tests PRIVATE $<$<COMPILE_LANGUAGE:CXX>:-O0>)
+    target_compile_options(run_all_unit_tests PRIVATE $<$<COMPILE_LANGUAGE:CXX>:-g>)
+    # explicitly disable coverage
+    target_compile_options(run_all_unit_tests PRIVATE -fno-profile-arcs -fno-test-coverage)
+    target_link_options(run_all_unit_tests PRIVATE -fno-profile-arcs -fno-test-coverage)
   endif()
 
-  if(USE_PETSC)
-    target_link_libraries(run_all_unit_tests ${PETSC_LIBRARY_DIRS})
-  endif()
+  # if(USE_TRILINOS)
+  #   target_link_libraries(run_all_unit_tests ${Trilinos_LIBRARIES} ${Trilinos_TPL_LIBRARIES})
+  # endif()
+
+  # if(USE_PETSC)
+  #   target_link_libraries(run_all_unit_tests ${PETSC_LIBRARY_DIRS})
+  # endif()
 
   # libraries
   target_link_libraries(run_all_unit_tests
+    solver
     ${GLOBAL_LIBRARIES}
     ${INTELRUNTIME_LIBRARIES}
     ${ZLIB_LIBRARY}
@@ -358,16 +375,27 @@ if(ENABLE_UNIT_TEST)
     ${TINYXML_LIBRARY_NAME}
     ${SV_LIB_LINEAR_SOLVER_NAME}${SV_MPI_NAME_EXT}
     ${VTK_LIBRARIES}
-  )
-
-  # link Google Test
-  target_link_libraries(
-    run_all_unit_tests
     gtest
     GTest::gtest_main 
-    pthread   # link pthread on ubuntu20
+    pthread 
   )
 
+  if(USE_TRILINOS)
+    target_link_libraries(run_all_unit_tests ${Trilinos_LIBRARIES} ${Trilinos_TPL_LIBRARIES})
+  endif()
+
+  if(USE_PETSC)
+    target_link_libraries(run_all_unit_tests ${PETSC_LIBRARY_DIRS})
+  endif()
+
+  # link Google Test
+  # target_link_libraries(
+  #   run_all_unit_tests
+  #   gtest
+  #   GTest::gtest_main 
+  #   pthread   # link pthread on ubuntu20
+  # )
+
   # gtest_discover_tests(runUnitTest)
   add_test(NAME all_unit_tests COMMAND run_all_unit_tests)