fix: browsersync works in ES module environment (#68)

Co-authored-by: tyler36 <[email protected]>

Author: tyler36

browser-sync.js renamed to browser-sync.cjs

@@ -7,4 +7,4 @@
 ## ExecRaw: true
 
 echo "Proxying browsersync on ${DDEV_PRIMARY_URL}:3000"
-browser-sync start -c /var/www/html/.ddev/browser-sync.js  | grep -v "Access URLs\|--------------------\|Local: http\|External: http"
+browser-sync start -c /var/www/html/.ddev/browser-sync.cjs  | grep -v "Access URLs\|--------------------\|Local: http\|External: http"

commands/web/browsersync

@@ -11,7 +11,7 @@ pre_install_actions:
 project_files:
   - config.browsersync.yaml
   - web-build/Dockerfile.ddev-browsersync
-  - browser-sync.js
+  - browser-sync.cjs
   - commands/web/browsersync
   - scripts/wp-config-ddev-browsersync.php
   - scripts/remove-wordpress-settings.sh
@@ -24,6 +24,10 @@ post_install_actions:
   if ( test -f "$HOME/.ddev/commands/web/browsersync" ) ; then
     echo "Note: '~/.ddev/commands/web/browsersync' is no longer required and can be safely removed." && exit 0
   fi
+  #ddev-description:Check for 'browser-sync.js'
+  if ( test -f "$DDEV_APPROOT/commands/web/browsersync.js" ) ; then
+    echo "Note: '$DDEV_APPROOT/commands/web/browsersync.js' is no longer required and can be safely removed." && exit 0
+  fi
   #ddev-nodisplay
   #ddev-description:Remove old 'docker-compose.browsersync.yaml'
   if grep "#ddev-generated" $DDEV_APPROOT/.ddev/docker-compose.browsersync.yaml 2>/dev/null; then rm -f "$DDEV_APPROOT/.ddev/docker-compose.browsersync.yaml"; fi

install.yaml

@@ -0,0 +1,4 @@
+{
+  "name": "test-browsersync",
+  "type": "module"
+}

tests/package.json

@@ -60,3 +60,21 @@ healthcheck() {
   # Check service works
   healthcheck
 }
+
+@test "ES module environment" {
+  set -eu -o pipefail
+  cd ${TESTDIR} || ( printf "unable to cd to ${TESTDIR}\n" && exit 1 )
+
+  # Setup NPM environment
+  cp "${DIR}/tests/package.json" "${TESTDIR}"
+
+  echo "# ddev get ${DIR} with project ${PROJNAME} in ${TESTDIR} ($(pwd))" >&3
+  ddev addon get ${DIR}
+
+  ddev restart
+  ./run-ddev-browsersync &
+  sleep 5
+
+  # Check service works
+  healthcheck
+}