Skip to content

Commit 70b1616

Browse files
authored
Please consider the following formatting changes (#412)
1 parent 3c291db commit 70b1616

File tree

3 files changed

+47
-41
lines changed

3 files changed

+47
-41
lines changed

Common/TableProducer/trackPropagationTester.cxx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111

1212
//===============================================================
1313
//
14-
// Experimental version of the track propagation task
14+
// Experimental version of the track propagation task
1515
// this utilizes an analysis task module that can be employed elsewhere
16-
// and allows for the re-utilization of a material LUT
17-
//
16+
// and allows for the re-utilization of a material LUT
17+
//
1818
// candidate approach for core service approach
1919
//
2020
//===============================================================
@@ -75,12 +75,12 @@ struct TrackPropagationTester {
7575
StandardCCDBLoader ccdbLoader;
7676
TrackPropagationModule trackPropagationMod;
7777

78-
// registry
78+
// registry
7979
HistogramRegistry registry{"registry"};
8080

8181
void init(o2::framework::InitContext& initContext)
8282
{
83-
// configure ccdb
83+
// configure ccdb
8484
ccdb->setURL(ccdbConfigurables.ccdburl);
8585
ccdb->setCaching(true);
8686
ccdb->setLocalObjectValidityChecking();
@@ -90,7 +90,7 @@ struct TrackPropagationTester {
9090
trackPropagationMod.initHistograms(registry, trackPropagationConfigurables);
9191
}
9292

93-
void processReal(soa::Join<aod::StoredTracksIU, aod::TracksCovIU, aod::TracksExtra> const& tracks, aod::Collisions const&, aod::BCs const& bcs)
93+
void processReal(soa::Join<aod::StoredTracksIU, aod::TracksCovIU, aod::TracksExtra> const& tracks, aod::Collisions const&, aod::BCs const& bcs)
9494
{
9595
ccdbLoader.initCCDBfromBCs(ccdb, bcs);
9696
trackPropagationMod.getFromCCDBLoader(ccdbLoader);
@@ -117,4 +117,5 @@ WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
117117
{
118118
WorkflowSpec workflow{adaptAnalysisTask<TrackPropagationTester>(cfgc)};
119119
return workflow;
120-
}
120+
}
121+

Common/Tools/StandardCCDBLoader.h

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
#include "Framework/AnalysisDataModel.h"
1919

2020
//__________________________________________
21-
// Standard class to load stuff
21+
// Standard class to load stuff
2222
// such as matLUT, B and mean Vertex
23-
// partial requests possible.
23+
// partial requests possible.
2424

2525
class StandardCCDBLoader
2626
{
@@ -53,7 +53,8 @@ class StandardCCDBLoader
5353

5454
// takes a configurableGroup and reads in necessary configs
5555
template <typename TConfigurableGroup>
56-
void readConfiguration(TConfigurableGroup const& cGroup){
56+
void readConfiguration(TConfigurableGroup const& cGroup)
57+
{
5758
ccdburl = cGroup.ccdburl.value;
5859
lutPath = cGroup.lutPath.value;
5960
geoPath = cGroup.geoPath.value;
@@ -65,11 +66,11 @@ class StandardCCDBLoader
6566
template <typename TCCDB, typename TBCs>
6667
void initCCDBfromBCs(TCCDB& ccdb, TBCs& bcs, bool getMeanVertex = true)
6768
{
68-
// instant load from BCs table. Bonus: protect also against empty bcs
69+
// instant load from BCs table. Bonus: protect also against empty bcs
6970
if (bcs.size() == 0) {
7071
return;
7172
}
72-
auto bc = bcs.begin();
73+
auto bc = bcs.begin();
7374
initCCDB(ccdb, bc.runNumber(), getMeanVertex);
7475
}
7576

@@ -93,15 +94,15 @@ class StandardCCDBLoader
9394
o2::base::Propagator::initFieldFromGRP(grpmag);
9495
LOG(info) << "Setting global propagator material propagation LUT";
9596
o2::base::Propagator::Instance()->setMatLUT(lut);
96-
if(getMeanVertex){
97+
if (getMeanVertex) {
9798
// only try this if explicitly requested
9899
mMeanVtx = ccdb->template getForRun<o2::dataformats::MeanVertexObject>(mVtxPath, currentRunNumber);
99-
}else{
100+
} else {
100101
mMeanVtx = nullptr;
101102
}
102103

103104
runNumber = currentRunNumber;
104105
}
105106
};
106107

107-
#endif // COMMON_TOOLS_STANDARDCCDBLOADER_H_
108+
#endif // COMMON_TOOLS_STANDARDCCDBLOADER_H_

Common/Tools/TrackPropagationModule.h

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
#include "Common/Tools/TrackTuner.h"
2222

2323
//__________________________________________
24-
// track propagation module
25-
//
24+
// track propagation module
25+
//
2626
// this class is capable of performing the usual track propagation
27-
// and table creation it is a demonstration of core service
28-
// plug-in functionality that could be used to reduce the number of
29-
// heavyweight (e.g. mat-LUT-using, propagating) core services to
30-
// reduce overhead and make it easier to pipeline / parallelize
27+
// and table creation it is a demonstration of core service
28+
// plug-in functionality that could be used to reduce the number of
29+
// heavyweight (e.g. mat-LUT-using, propagating) core services to
30+
// reduce overhead and make it easier to pipeline / parallelize
3131
// bottlenecks in core services
3232

3333
class TrackPropagationModule
@@ -36,19 +36,19 @@ class TrackPropagationModule
3636
TrackPropagationModule()
3737
{
3838
// constructor: set defaults
39-
minPropagationRadius = o2::constants::geom::XTPCInnerRef + 0.1;
39+
minPropagationRadius = o2::constants::geom::XTPCInnerRef + 0.1;
4040
useTrackTuner = false;
41-
useTrkPid = false;
42-
fillTrackTunerTable = false;
41+
useTrkPid = false;
42+
fillTrackTunerTable = false;
4343
trackTunerConfigSource = o2::aod::track_tuner::InputString;
4444
std::string trackTunerParams = "debugInfo=0|updateTrackDCAs=1|updateTrackCovMat=1|updateCurvature=0|updateCurvatureIU=0|updatePulls=0|isInputFileFromCCDB=1|pathInputFile=Users/m/mfaggin/test/inputsTrackTuner/PbPb2022|nameInputFile=trackTuner_DataLHC22sPass5_McLHC22l1b2_run529397.root|pathFileQoverPt=Users/h/hsharma/qOverPtGraphs|nameFileQoverPt=D0sigma_Data_removal_itstps_MC_LHC22b1b.root|usePvRefitCorrections=0|qOverPtMC=-1.|qOverPtData=-1.";
4545
};
4646

47-
float minPropagationRadius;
48-
bool useTrackTuner;
47+
float minPropagationRadius;
48+
bool useTrackTuner;
4949
bool useTrkPid;
50-
bool fillTrackTunerTable;
51-
int trackTunerConfigSource;
50+
bool fillTrackTunerTable;
51+
int trackTunerConfigSource;
5252
std::string trackTunerParams;
5353

5454
// controls behaviour
@@ -74,7 +74,8 @@ class TrackPropagationModule
7474

7575
// takes a configurableGroup and reads in necessary configs
7676
template <typename TConfigurableGroup>
77-
void readConfiguration(TConfigurableGroup const& cGroup){
77+
void readConfiguration(TConfigurableGroup const& cGroup)
78+
{
7879
minPropagationRadius = cGroup.minPropagationRadius.value;
7980
useTrackTuner = cGroup.minPropagationRadius.value;
8081
useTrkPid = cGroup.useTrkPid.value;
@@ -84,14 +85,16 @@ class TrackPropagationModule
8485
LOGF(info, "Track propagation module configuration done.");
8586
}
8687
template <typename TCCDBLoader>
87-
void getFromCCDBLoader(TCCDBLoader const& loader){
88+
void getFromCCDBLoader(TCCDBLoader const& loader)
89+
{
8890
lut = loader.lut;
8991
mMeanVtx = loader.mMeanVtx;
9092
grpmag = loader.grpmag;
9193
}
9294

9395
template <typename TInitContext>
94-
void init(TInitContext& initContext){
96+
void init(TInitContext& initContext)
97+
{
9598
// Checking if the tables are requested in the workflow and enabling them
9699
fillTracksCov = isTableRequiredInWorkflow(initContext, "TracksCov");
97100
fillTracksDCA = isTableRequiredInWorkflow(initContext, "TracksDCA");
@@ -118,15 +121,16 @@ class TrackPropagationModule
118121
}
119122

120123
template <typename THistoRegistry, typename TConfigurableGroup>
121-
void initHistograms(THistoRegistry& registry, TConfigurableGroup& cGroup){
124+
void initHistograms(THistoRegistry& registry, TConfigurableGroup& cGroup)
125+
{
122126
trackTunedTracks = registry.template add<TH1>("trackTunedTracks", "trackTunedTracks", o2::framework::kTH1D, {{1, 0.5f, 1.5f}});
123-
127+
124128
// Histograms for track tuner
125129
o2::framework::AxisSpec axisBinsDCA = {600, -0.15f, 0.15f, "#it{dca}_{xy} (cm)"};
126130
registry.template add("hDCAxyVsPtRec", "hDCAxyVsPtRec", o2::framework::kTH2F, {axisBinsDCA, cGroup.axisPtQA});
127131
registry.template add("hDCAxyVsPtMC", "hDCAxyVsPtMC", o2::framework::kTH2F, {axisBinsDCA, cGroup.axisPtQA});
128132
registry.template add("hDCAzVsPtRec", "hDCAzVsPtRec", o2::framework::kTH2F, {axisBinsDCA, cGroup.axisPtQA});
129-
registry.template add("hDCAzVsPtMC", "hDCAzVsPtMC", o2::framework::kTH2F, {axisBinsDCA, cGroup.axisPtQA});
133+
registry.template add("hDCAzVsPtMC", "hDCAzVsPtMC", o2::framework::kTH2F, {axisBinsDCA, cGroup.axisPtQA});
130134
}
131135

132136
template <bool isMc, typename TTracks, typename TOutputGroup, typename THistoRegistry>
@@ -172,7 +176,7 @@ class TrackPropagationModule
172176
double q2OverPtNew = -9999.;
173177
// Only propagate tracks which have passed the innermost wall of the TPC (e.g. skipping loopers etc). Others fill unpropagated.
174178
if (track.trackType() == o2::aod::track::TrackIU && track.x() < minPropagationRadius) {
175-
if(fillTracksCov){
179+
if (fillTracksCov) {
176180
if constexpr (isMc) { // checking MC and fillCovMat block begins
177181
// bool hasMcParticle = track.has_mcParticle();
178182
if (useTrackTuner) {
@@ -210,7 +214,7 @@ class TrackPropagationModule
210214
trackType = o2::aod::track::Track;
211215
}
212216
// filling some QA histograms for track tuner test purpose
213-
if(fillTracksCov){
217+
if (fillTracksCov) {
214218
if constexpr (isMc) { // checking MC and fillCovMat block begins
215219
if (track.has_mcParticle() && isPropagationOK) {
216220
auto mcParticle1 = track.mcParticle();
@@ -235,11 +239,11 @@ class TrackPropagationModule
235239
cursors.tracksParExtensionPropagated(mTrackParCov.getPt(), mTrackParCov.getP(), mTrackParCov.getEta(), mTrackParCov.getPhi());
236240
// TODO do we keep the rho as 0? Also the sigma's are duplicated information
237241
cursors.tracksParCovPropagated(std::sqrt(mTrackParCov.getSigmaY2()), std::sqrt(mTrackParCov.getSigmaZ2()), std::sqrt(mTrackParCov.getSigmaSnp2()),
238-
std::sqrt(mTrackParCov.getSigmaTgl2()), std::sqrt(mTrackParCov.getSigma1Pt2()), 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
242+
std::sqrt(mTrackParCov.getSigmaTgl2()), std::sqrt(mTrackParCov.getSigma1Pt2()), 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
239243
cursors.tracksParCovExtensionPropagated(mTrackParCov.getSigmaY2(), mTrackParCov.getSigmaZY(), mTrackParCov.getSigmaZ2(), mTrackParCov.getSigmaSnpY(),
240-
mTrackParCov.getSigmaSnpZ(), mTrackParCov.getSigmaSnp2(), mTrackParCov.getSigmaTglY(), mTrackParCov.getSigmaTglZ(), mTrackParCov.getSigmaTglSnp(),
241-
mTrackParCov.getSigmaTgl2(), mTrackParCov.getSigma1PtY(), mTrackParCov.getSigma1PtZ(), mTrackParCov.getSigma1PtSnp(), mTrackParCov.getSigma1PtTgl(),
242-
mTrackParCov.getSigma1Pt2());
244+
mTrackParCov.getSigmaSnpZ(), mTrackParCov.getSigmaSnp2(), mTrackParCov.getSigmaTglY(), mTrackParCov.getSigmaTglZ(), mTrackParCov.getSigmaTglSnp(),
245+
mTrackParCov.getSigmaTgl2(), mTrackParCov.getSigma1PtY(), mTrackParCov.getSigma1PtZ(), mTrackParCov.getSigma1PtSnp(), mTrackParCov.getSigma1PtTgl(),
246+
mTrackParCov.getSigma1Pt2());
243247
if (fillTracksDCA) {
244248
cursors.tracksDCA(mDcaInfoCov.getY(), mDcaInfoCov.getZ());
245249
}
@@ -257,4 +261,4 @@ class TrackPropagationModule
257261
}
258262
};
259263

260-
#endif // COMMON_TOOLS_TRACKPROPAGATIONMODULE_H_
264+
#endif // COMMON_TOOLS_TRACKPROPAGATIONMODULE_H_

0 commit comments

Comments
 (0)