correcting value shifting

usa-m · usa-m · commit c3dd3d0ac41f · 2023-04-09T20:58:44.000+05:00
diff --git a/src/dds.net-connector-csharp.lib/EncodersAndDecoders/PacketPreprocessor.cs b/src/dds.net-connector-csharp.lib/EncodersAndDecoders/PacketPreprocessor.cs
@@ -49,21 +49,14 @@ internal void AddData(PacketFromServer packet)
                 //- 
                 //- Compacting the buffer
                 //- 
-                if (bufferNextWriteIndex != bufferStartIndex)
+                if (bufferStartIndex > 0)
                 {
-                    int timesShifted = 0;
                     for (int i = 0; i < (bufferNextWriteIndex - bufferStartIndex); i++)
                     {
                         buffer[i] = buffer[bufferStartIndex + i];
-                        timesShifted++;
                     }
 
-                    bufferStartIndex = 0;
-                    bufferNextWriteIndex -= timesShifted;
-                }
-                else
-                {
-                    bufferNextWriteIndex = 0;
+                    bufferNextWriteIndex -= bufferStartIndex;
                     bufferStartIndex = 0;
                 }
 
@@ -163,8 +156,6 @@ internal byte[] GetSingleMessage()
                         index++;
                     }
 
-                    previousDataStartIndex = bufferStartIndex;
-
                     return null!;
                 }
                 //- 

Original file line number	Diff line number	Diff line change
`@@ -49,21 +49,14 @@ internal void AddData(PacketFromServer packet)`
`49`	`49`	`//-`
`50`	`50`	`//- Compacting the buffer`
`51`	`51`	`//-`
`52`		`- if (bufferNextWriteIndex != bufferStartIndex)`
	`52`	`+ if (bufferStartIndex > 0)`
`53`	`53`	`{`
`54`		`- int timesShifted = 0;`
`55`	`54`	`for (int i = 0; i < (bufferNextWriteIndex - bufferStartIndex); i++)`
`56`	`55`	`{`
`57`	`56`	`buffer[i] = buffer[bufferStartIndex + i];`
`58`		`- timesShifted++;`
`59`	`57`	`}`
`60`	`58`
`61`		`- bufferStartIndex = 0;`
`62`		`- bufferNextWriteIndex -= timesShifted;`
`63`		`- }`
`64`		`- else`
`65`		`- {`
`66`		`- bufferNextWriteIndex = 0;`
	`59`	`+ bufferNextWriteIndex -= bufferStartIndex;`
`67`	`60`	`bufferStartIndex = 0;`
`68`	`61`	`}`
`69`	`62`
`@@ -163,8 +156,6 @@ internal byte[] GetSingleMessage()`
`163`	`156`	`index++;`
`164`	`157`	`}`
`165`	`158`
`166`		`- previousDataStartIndex = bufferStartIndex;`
`167`		`-`
`168`	`159`	`return null!;`
`169`	`160`	`}`
`170`	`161`	`//-`