PSBT: Clean up PSBT chunk allocations

Cleaning up the memory hierarchy of PSBT usage in splicing and `psbt_finalize_input`

Author: ddustin

channeld/channeld.c

@@ -4234,7 +4234,7 @@ static void splice_initiator_user_update(struct peer *peer, const u8 *inmsg)
 
 	/* Peer may have modified our PSBT so we return it to the user here */
 	outmsg = towire_channeld_splice_confirmed_update(NULL,
-							 ictx->current_psbt,
+							 peer->splicing->current_psbt,
 							 false, false);
 	wire_sync_write(MASTER_FD, take(outmsg));
 	audit_psbt(peer->splicing->current_psbt, peer->splicing->current_psbt);
@@ -4275,7 +4275,7 @@ static void splice_initiator_user_signed(struct peer *peer, const u8 *inmsg)
 		return;
 	}
 
-	if (!fromwire_channeld_splice_signed(inflight, inmsg, &signed_psbt,
+	if (!fromwire_channeld_splice_signed(tmpctx, inmsg, &signed_psbt,
 					     &peer->splicing->force_sign_first))
 		master_badmsg(WIRE_CHANNELD_SPLICE_SIGNED, inmsg);
 

common/interactivetx.c

@@ -588,7 +588,7 @@ char *process_interactivetx_updates(const tal_t *ctx,
 
 			tal_wally_start();
 			wally_psbt_input_set_utxo(in, tx->wtx);
-			tal_wally_end(ictx);
+			tal_wally_end(ictx->current_psbt);
 
 			psbt_input_set_serial_id(ictx->current_psbt,
 						 in, serial_id);

common/psbt_internal.c

@@ -106,10 +106,12 @@ void psbt_finalize_input(const tal_t *ctx,
 					       redeem_script->value,
 					       redeem_script->value_len, 0);
 		u8 *final_scriptsig =
-			bitcoin_scriptsig_redeem(NULL,
+			bitcoin_scriptsig_redeem(ctx,
 						 take(redeemscript));
+		tal_wally_start();
 		wally_psbt_input_set_final_scriptsig(in, final_scriptsig, tal_bytelen(final_scriptsig));
-		wally_psbt_input_set_redeem_script(in, tal_arr(NULL, u8, 0), 0);
+		wally_psbt_input_set_redeem_script(in, tal_arr(in, u8, 0), 0);
+		tal_wally_end(ctx);
 	}
 }