common: remove take() leak if new_initial_channel() fails.

This happens in the fuzzer corpora, but that doesn't check for take()
leaks.  Our unit tests do:

```
fuzz-initial_channel: outstanding taken(): 0x626c3b3affc8
make: *** [Makefile:823: unittest/tests/fuzz/fuzz-initial_channel] Error 1
```

This doesn't matter in real life, since we exit the subdaemon if this
fails, but it's still a bug.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

common/initial_channel.c

@@ -31,6 +31,19 @@ struct channel *new_initial_channel(const tal_t *ctx,
 	struct channel *channel = tal(ctx, struct channel);
 	struct amount_msat remote_msatoshi;
 
+	/* takes() if necessary */
+	channel->fee_states = dup_fee_states(channel, fee_states);
+
+	/* takes() if necessary */
+	if (!height_states)
+		channel->blockheight_states = NULL;
+	else
+		channel->blockheight_states
+			= dup_height_states(channel, height_states);
+
+	/* takes() if necessary */
+	channel->type = tal_dup(channel, struct channel_type, type);
+
 	channel->cid = *cid;
 	channel->funding = *funding;
 	channel->funding_sats = funding_sats;
@@ -47,16 +60,6 @@ struct channel *new_initial_channel(const tal_t *ctx,
 	channel->funding_pubkey[REMOTE] = *remote_funding_pubkey;
 	channel->htlcs = NULL;
 
-	/* takes() if necessary */
-	channel->fee_states = dup_fee_states(channel, fee_states);
-
-	/* takes() if necessary */
-	if (!height_states)
-		channel->blockheight_states = NULL;
-	else
-		channel->blockheight_states
-			= dup_height_states(channel, height_states);
-
 	channel->view[LOCAL].owed[LOCAL]
 		= channel->view[REMOTE].owed[LOCAL]
 		= local_msatoshi;
@@ -77,8 +80,6 @@ struct channel *new_initial_channel(const tal_t *ctx,
 					 &channel->basepoints[!opener].payment);
 
 	channel->option_wumbo = option_wumbo;
-	/* takes() if necessary */
-	channel->type = tal_dup(channel, struct channel_type, type);
 
 	return channel;
 }