Skip to content

Issues with notify.notify in release version #187

Description

@deafmute1

Two issues that I encountered with notify due to undocumented/wrong documented behavior.

  1. Version downloaded via pip has different signature vs main/docs.
    Pip version has signature notify(title, subtitle, message, sound), and raises ValueError if message == '', but main/docs have signature notify(title, subtitle, sound) with value error if title == subtitle == ''. I kept calling this function exactly as docs describe but getting ValueError...

  2. notify.notify requires you have a file at workflowdir/icon.png, otherwise you get somewhat cryptic error. It doesn't describe the need for an icon anywhere in this project's docs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions