Bug: Fix type checking issue found when GOLFing already GOLFed output.

DeanEdisGG · DeanEdisGG · commit 78216f81ff10 · 2022-04-18T12:33:57.000+01:00
diff --git a/ShaderShrinker/Shrinker.Parser/Optimizations/ReplaceFunctionCallsWithResultExtension.cs b/ShaderShrinker/Shrinker.Parser/Optimizations/ReplaceFunctionCallsWithResultExtension.cs
@@ -50,6 +50,9 @@ public static bool ReplaceFunctionCallsWithResult(this SyntaxNode rootNode)
                         }
 
                         var typeNode = (GenericSyntaxNode)callee.Params.Children[i++].Clone();
+                        if (typeNode?.Token is not TypeToken)
+                            continue; // Unknown type - Skip.
+
                         var nameNode = (GenericSyntaxNode)callee.Params.Children[i++].Clone();
 
                         var declNode = new VariableDeclarationSyntaxNode(typeNode);

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ public static bool ReplaceFunctionCallsWithResult(this SyntaxNode rootNode)`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`var typeNode = (GenericSyntaxNode)callee.Params.Children[i++].Clone();`
	`53`	`+ if (typeNode?.Token is not TypeToken)`
	`54`	`+ continue; // Unknown type - Skip.`
	`55`	`+`
`53`	`56`	`var nameNode = (GenericSyntaxNode)callee.Params.Children[i++].Clone();`
`54`	`57`
`55`	`58`	`var declNode = new VariableDeclarationSyntaxNode(typeNode);`