Improve test coverage

Author: dearchap

args_test.go

@@ -8,6 +8,15 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestArgNotSet(t *testing.T) {
+	arg := &StringArg{
+		Name:  "sa",
+		Value: "foo",
+	}
+
+	require.Equal(t, "foo", arg.Get())
+}
+
 func TestArgsFloatTypes(t *testing.T) {
 	cmd := buildMinimalTestCommand()
 	var fval float64

command.go

@@ -334,14 +334,10 @@ func (cmd *Command) handleExitCoder(ctx context.Context, err error) error {
 }
 
 func (cmd *Command) argsWithDefaultCommand(oldArgs Args) Args {
-	if cmd.DefaultCommand != "" {
-		rawArgs := append([]string{cmd.DefaultCommand}, oldArgs.Slice()...)
-		newArgs := &stringSliceArgs{v: rawArgs}
+	rawArgs := append([]string{cmd.DefaultCommand}, oldArgs.Slice()...)
+	newArgs := &stringSliceArgs{v: rawArgs}
 
-		return newArgs
-	}
-
-	return oldArgs
+	return newArgs
 }
 
 // Root returns the Command at the root of the graph

flag.go

@@ -77,11 +77,6 @@ func (f FlagsByName) Len() int {
 }
 
 func (f FlagsByName) Less(i, j int) bool {
-	if len(f[j].Names()) == 0 {
-		return false
-	} else if len(f[i].Names()) == 0 {
-		return true
-	}
 	return lexicographicLess(f[i].Names()[0], f[j].Names()[0])
 }
 

flag_test.go

@@ -1749,6 +1749,29 @@ func TestFlagActionFromEnv(t *testing.T) {
 	assert.Equal(t, x, 42)
 }
 
+func TestParseShortOptionBoolError(t *testing.T) {
+	cmd := buildMinimalTestCommand()
+	cmd.UseShortOptionHandling = true
+	cmd.Flags = []Flag{
+		&BoolFlag{Name: "debug", Aliases: []string{"d"}},
+		&BoolFlag{Name: "verbose", Aliases: []string{"v"}},
+	}
+
+	err := cmd.Run(buildTestContext(t), []string{"run", "-vd=notabool"})
+	assert.Error(t, err, "expected error parsing invalid bool")
+}
+
+func TestParseShortOptionIntError(t *testing.T) {
+	cmd := buildMinimalTestCommand()
+	cmd.Flags = []Flag{
+		&IntFlag{Name: "port", Aliases: []string{"p"}},
+		&BoolFlag{Name: "debug", Aliases: []string{"d"}},
+	}
+
+	err := cmd.Run(buildTestContext(t), []string{"run", "-dp=notanint"})
+	assert.Error(t, err, "expected error parsing invalid int")
+}
+
 func TestParseMultiString(t *testing.T) {
 	_ = (&Command{
 		Flags: []Flag{
@@ -3294,6 +3317,17 @@ func TestFileHint(t *testing.T) {
 	assert.Equal(t, "bar [/tmp/foo.txt]", withFileHint("/tmp/foo.txt", "bar"))
 }
 
+func TestHasFlags(t *testing.T) {
+	flagToCheck := &StringFlag{Name: "foo"}
+	flags := []Flag{
+		&StringFlag{Name: "bar"},
+		&Int64Flag{Name: "baz"},
+		flagToCheck,
+	}
+
+	assert.True(t, hasFlag(flags, flagToCheck))
+}
+
 func TestFlagsByName(t *testing.T) {
 	flags := []Flag{
 		&StringFlag{