Merge pull request urfave#2003 from urfave/bartekpacia/fix/build_error_output

bartekpacia · web-flow · commit 83cb4dd8e41f · 2024-11-02T23:55:30.000+01:00
improve output of build.go#downloadFile when download fails
diff --git a/scripts/build.go b/scripts/build.go
@@ -208,7 +208,7 @@ func downloadFile(src, dest string, dirPerm, perm os.FileMode) error {
 	defer resp.Body.Close()
 
 	if resp.StatusCode >= 300 {
-		return fmt.Errorf("download response %[1]v", resp.StatusCode)
+		return fmt.Errorf("download file from %[2]s into %[3]s: response %[1]v", resp.StatusCode, src, dest)
 	}
 
 	if err := os.MkdirAll(filepath.Dir(dest), dirPerm); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ func downloadFile(src, dest string, dirPerm, perm os.FileMode) error {`
`208`	`208`	`defer resp.Body.Close()`
`209`	`209`
`210`	`210`	`if resp.StatusCode >= 300 {`
`211`		`- return fmt.Errorf("download response %[1]v", resp.StatusCode)`
	`211`	`+ return fmt.Errorf("download file from %[2]s into %[3]s: response %[1]v", resp.StatusCode, src, dest)`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`if err := os.MkdirAll(filepath.Dir(dest), dirPerm); err != nil {`